From patchwork Thu May 15 12:00:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23369 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9526FC328D for ; Thu, 15 May 2025 12:00:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EA84A68D6B; Thu, 15 May 2025 14:00:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="T+2F5etH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F9CC68B70 for ; Thu, 15 May 2025 14:00:17 +0200 (CEST) Received: from pb-laptop.local (185.221.142.248.nat.pool.zt.hu [185.221.142.248]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FD13886; Thu, 15 May 2025 14:00:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1747310400; bh=O/0GBjFh9O7FN9IdFr4qs/b/FCsajvZOuZVKvXKVcwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T+2F5etHll52Ud9QoUVz1+qxkAptid12bAbqQDFB9d4M/1IL4S15IsNWeMgdyxH/P ZlKU+veJ3onnwdaLmFuTzXo2km8efmBTlpNCeW9vF6qzX70+7P4Y8cQCvHca4wRJoN 1iQXZ2b58mA42JMLbsgik5RO1l+U/P9F3Va6H5AA= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [RFC PATCH v1 4/8] utils: codegen: ipc: Log error code when remote call fails Date: Thu, 15 May 2025 14:00:08 +0200 Message-ID: <20250515120012.3127231-5-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250515120012.3127231-1-barnabas.pocze@ideasonboard.com> References: <20250515120012.3127231-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The error code can be useful in diagnosing the underlying issue, so log that as well, not just the existence of the issue. Signed-off-by: Barnabás Pőcze Reviewed-by: Paul Elder --- .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl index 07165821e..effc8f7dd 100644 --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl @@ -206,7 +206,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data) ); {%- endif %} if (_ret < 0) { - LOG(IPAProxy, Error) << "Failed to call {{method.mojom_name}}"; + LOG(IPAProxy, Error) << "Failed to call {{method.mojom_name}}: " << _ret; {%- if method|method_return_value != "void" %} return static_cast<{{method|method_return_value}}>(_ret); {%- else %}