From patchwork Tue Apr 29 07:53:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23296 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AE558C327D for ; Tue, 29 Apr 2025 07:53:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7286668AD6; Tue, 29 Apr 2025 09:53:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LpgTO9YP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D97F4617DF for ; Tue, 29 Apr 2025 09:53:24 +0200 (CEST) Received: from pb-laptop.local (185.221.141.190.nat.pool.zt.hu [185.221.141.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 396964CE for ; Tue, 29 Apr 2025 09:53:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1745913199; bh=kDYtW527eXitHXwkq+TcO/P3kY2fPsRf9wvdtVgXOcQ=; h=From:To:Subject:Date:From; b=LpgTO9YP25eGSCg4DdY8WquRG2XhZe1q643nfPgcXSyoRJfNa1XIBr82acc3k4ISa 3LX5LP+C/oIM+XWLDNWE5EASv+2dRgv9wgaPvUDk1ekGEiq4Qc93654TEiMw4ePmxq cAa1Nw0xwQCKELEao6EY6d7EspvtO2nEQgMj+4OA= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2] ipa: rpi: awb: Remove "fast" parameter Date: Tue, 29 Apr 2025 09:53:21 +0200 Message-ID: <20250429075321.2085445-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The "fast" parameter has not been used since it first appeared in the source code. And not only is it not used, but its retrieval from the configuration since c1597f989654 ("ipa: raspberrypi: Use YamlParser to replace dependency on boost") has been incorrect. So remove it. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: David Plowman --- changes in v2: * remove it altogether v1: https://patchwork.libcamera.org/patch/20076/ --- src/ipa/rpi/controller/rpi/awb.cpp | 1 - src/ipa/rpi/controller/rpi/awb.h | 1 - 2 files changed, 2 deletions(-) -- 2.49.0 diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp index 8479ae409..365b595ff 100644 --- a/src/ipa/rpi/controller/rpi/awb.cpp +++ b/src/ipa/rpi/controller/rpi/awb.cpp @@ -165,7 +165,6 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms) bayes = false; } } - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */ whitepointR = params["whitepoint_r"].get(0.0); whitepointB = params["whitepoint_b"].get(0.0); if (bayes == false) diff --git a/src/ipa/rpi/controller/rpi/awb.h b/src/ipa/rpi/controller/rpi/awb.h index 86640f8f8..2fb912541 100644 --- a/src/ipa/rpi/controller/rpi/awb.h +++ b/src/ipa/rpi/controller/rpi/awb.h @@ -43,7 +43,6 @@ struct AwbConfig { uint16_t startupFrames; unsigned int convergenceFrames; /* approx number of frames to converge */ double speed; /* IIR filter speed applied to algorithm results */ - bool fast; /* "fast" mode uses a 16x16 rather than 32x32 grid */ libcamera::ipa::Pwl ctR; /* function maps CT to r (= R/G) */ libcamera::ipa::Pwl ctB; /* function maps CT to b (= B/G) */ libcamera::ipa::Pwl ctRInverse; /* inverse of ctR */