From patchwork Tue Apr 22 21:59:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 23236 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DC075C32A2 for ; Tue, 22 Apr 2025 22:00:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D525868B36; Wed, 23 Apr 2025 00:00:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NvOLafmz"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C779268B40 for ; Tue, 22 Apr 2025 23:59:45 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf257158fso37902725e9.2 for ; Tue, 22 Apr 2025 14:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745359185; x=1745963985; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aHV/OzBettE9JMBz8rxXsO0JyXp6g3150ZsuVLe9cQ0=; b=NvOLafmzSzR7jvTcURNl+cWoaOLGe/dIQkj+lZctBmB5t+Pw8gSEv/WN9jSe0jmnJJ 43ZGYDJacBAoU0Xv3LXWA/qXYV0ysgFvvQtnHB33Hg6q4zTtKx34Ej01Len0aiAmUrE6 gnD3zrp95IwwUtrdb57f3bx0vM62wocix8KW2aISU/cbGmnFT+bwaftyY4LsJ+ZPlhU/ 1lEDBVuGk8idBemgG76psjnpRM1quZKZ+yU6tOA8vQqM0tH/cf55pT9bOs3mXxppkdvb pIzkrEXX/zvi1KCGwHIPN8hR+LUFax+9tSG9VgeX/YCZwWKrskvSYpm0YsziuzEUdBgV EfpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745359185; x=1745963985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aHV/OzBettE9JMBz8rxXsO0JyXp6g3150ZsuVLe9cQ0=; b=jjVm0RlA7fypuTIDGxIfE478UMiiJijpze3uHfB3wZWKTAHQOL7+SQopTloZL4Nq4J +6oE5KY83zaliKeL1JTQbTBzf5xo94U73V7s/SnLMgebBT5saz2jcL0oiAHI020hz2AG TQ3K8MTIi8AAfHydwFghPIJK4WPZ2XjUTooxSKq1vHbFIOHr5EDvABhJ67g33b+nmpD7 yW6O02kNzza6lQ5HE+/RM1ZV3eNG/MiN3DKu3HwZ9Zyh+rIMyrVznxdIGVSu3nuvMu8g e+yzHNV1OcwOKTFQ3flRftNcqUEx18012LRC+/PAHXQeINyAhUV7jWUCOxo9DJgO50ON AOkA== X-Gm-Message-State: AOJu0YwoHErErEdgnbJ4IHD9VAlOSVIe/FC4UZPFA4B1b0epsm2Ori0g AOJuU0nLyNxAa/500ZX8Ca5uGNEwPCKCJk6Nz0SgoFYQdMFoXCsOtcUE2be4aZ4slpUlfeqdeYD 6/QI= X-Gm-Gg: ASbGncswv0C1iB3Eynkm92HAcnp2XfDVAq1mKtkj6oHYpPTTvV+YcOvjwiS48rZW3U6 Ro8o2nmVPRJ/+Ydlrx1+Iqdkr6oya8Mzcxzt38Hskaysc9DKyVGTxJ1LGd9Ce3SKGvTWWGbv94G XOzI5VHL86LXdYnalz35A96J4MzFj97vy9u8vJPRamzEAWoLRA6iq+hdjjqdg8kRA2vLsh9SWUd GNcGVtwTaMPM2kX1IaCA4ixAcST1RwJ38tJ8b5QQ/G5iuMOz6nnIMicUsCI8lpqTOpYAx7eit3H 9unQwvIMT7m9J9t7H8P7prSYi6piZyVwNEccDgJ7rTYavPgGRpTEeYmri+fdCtNy3+fEaDw7mWz xBYWhz4n9OeoELJc9wC8kukqd5bkf5gs= X-Google-Smtp-Source: AGHT+IGoNtvjoDWPqZBIAPAQUPdPrlP+qS7fUcII/7qdawBqNzL9XJABbhc6SBUpmFTbrITLwCmQCw== X-Received: by 2002:a05:600c:1d0d:b0:43c:fae1:5151 with SMTP id 5b1f17b1804b1-4406abf90f4mr114923525e9.25.1745359185199; Tue, 22 Apr 2025 14:59:45 -0700 (PDT) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 14:59:44 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org, bod.linux@nxsw.ie Subject: [PATCH 23/27] libcamera: shaders: Use highp not mediump for float precision Date: Tue, 22 Apr 2025 22:59:16 +0100 Message-ID: <20250422215920.4297-24-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422215920.4297-1-bryan.odonoghue@linaro.org> References: <20250422215920.4297-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We get better sample resolution with highp instead of mediump. Signed-off-by: Bryan O'Donoghue --- src/apps/qcam/assets/shader/RGB.frag | 2 +- src/apps/qcam/assets/shader/YUV_2_planes.frag | 2 +- src/apps/qcam/assets/shader/YUV_3_planes.frag | 2 +- src/apps/qcam/assets/shader/YUV_packed.frag | 2 +- src/apps/qcam/assets/shader/bayer_1x_packed.frag | 2 +- src/apps/qcam/assets/shader/bayer_8.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/apps/qcam/assets/shader/RGB.frag b/src/apps/qcam/assets/shader/RGB.frag index 4c374ac9..72439589 100644 --- a/src/apps/qcam/assets/shader/RGB.frag +++ b/src/apps/qcam/assets/shader/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/apps/qcam/assets/shader/YUV_2_planes.frag b/src/apps/qcam/assets/shader/YUV_2_planes.frag index 1d5d1206..d286f117 100644 --- a/src/apps/qcam/assets/shader/YUV_2_planes.frag +++ b/src/apps/qcam/assets/shader/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/apps/qcam/assets/shader/YUV_3_planes.frag b/src/apps/qcam/assets/shader/YUV_3_planes.frag index 8f788e90..8e3e0b4a 100644 --- a/src/apps/qcam/assets/shader/YUV_3_planes.frag +++ b/src/apps/qcam/assets/shader/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/apps/qcam/assets/shader/YUV_packed.frag b/src/apps/qcam/assets/shader/YUV_packed.frag index b9ef9d41..3c9e3e39 100644 --- a/src/apps/qcam/assets/shader/YUV_packed.frag +++ b/src/apps/qcam/assets/shader/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/apps/qcam/assets/shader/bayer_1x_packed.frag b/src/apps/qcam/assets/shader/bayer_1x_packed.frag index f53f5575..19b13ad0 100644 --- a/src/apps/qcam/assets/shader/bayer_1x_packed.frag +++ b/src/apps/qcam/assets/shader/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/apps/qcam/assets/shader/bayer_8.frag b/src/apps/qcam/assets/shader/bayer_8.frag index 7e35ca88..aa7a1b00 100644 --- a/src/apps/qcam/assets/shader/bayer_8.frag +++ b/src/apps/qcam/assets/shader/bayer_8.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/