From patchwork Tue Apr 22 14:25:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaslo Ziska X-Patchwork-Id: 23211 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 67293BE08B for ; Tue, 22 Apr 2025 14:29:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1AA4E68AD4; Tue, 22 Apr 2025 16:29:53 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ziska.de header.i=@ziska.de header.b="VpE5fTvJ"; dkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de header.b="HvnBPelj"; dkim-atps=neutral Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF9BD68AC5 for ; Tue, 22 Apr 2025 16:29:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1745332191; cv=none; d=strato.com; s=strato-dkim-0002; b=NlO09xhz+GXmXvF3ZHBBv291QfOv64T9QcXZoQGEjfz3UiTgqVIONmbs4CyXfYOxX4 wjf3GsfiYfUJrPqE3EzDlVk1f7th9lC+cDb0Bt5ojAweeVHErZ2qeq61fcS+/4qsafs9 l7bLtIMDmtnp0a5P4t99m6yXkuTnbskTdBFsUpJkLSduvwrI1h3g9OEUiEePXOztXK2N BccYVtgYBN48KCi8vHGCZIp9aM5+Dni7k8fSlpbNAoYb1R/OY+ilZyjCdijtiNJrI9h5 IprfLMdt6NuaMOvsMGzSUxVIajWXQRrGTdzI0jPT6cOmiiV8PlpaTfjzPNI1hKkVCnDT Syuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1745332191; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=; b=OcptjT0LZPnMHjSifrp4am1pdvDHQpfsFfTNcRcQRLyPyF0NH1honXh6/yg3tkBnuZ F9QVpW35mrnFM0SvbILecVUjL9SCHAGVmp9RsSXG5k2KvOD/4yHqHkdZVoLqt9jtC/OK hPbhUu+1slmYKkI4LSbmgy6uZvHdOSZh5SuPwA30PG/4bihQzEHQOsFOYXkJlEg5wAgz hQNQ8Dlczwyb6ozWp+O/8VPfeYWMmNYTsu1nwfvBiIi1iP3CsuN9Trx//fphwp0yvQHX 2q6Jv7P3Lr+dAmR2i1GZ+Zsh1Q4jcRoJ3t8/swaGn47ZhbkZAhSTYZxuAGLLFbwYa8e9 joaA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1745332191; s=strato-dkim-0002; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=; b=VpE5fTvJGX7qpKQ6VCE1hpIvBj+9RUfZEREjr0BWkdhG0PuJqiBCxDRhJSXdjEFeIh AUDE8qx4/FnnN4VMLRH5Jv6LI6vS3jXVqJhBxx3WpIfXgav4T4S0kIdFI8JV8cUpFlpV PEKjLnbMY83shZZSGH88d3CcyCioDcueTg8sNc3TFgvZm2MtdcFCHVahnXwYVfy3Br3r uvf7Y2U+XggdE93GU1qgXJuApCWJ/JD47nNLqOsQ1owV3YmPgO2R643X5pvBMoD2xqRP JN2p+f13bbJNsmf5H4d/3VedYPYZVE9VeTMKMyAj8viaYx8dpusVVHeXEwzFvfpMRQit HrCA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1745332191; s=strato-dkim-0003; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=; b=HvnBPeljPBXRhje7B5j6lb3hH2XCezsfok12C8Q0etJINyrcus2ew0diJEKIVSLRAa nbCmA8ZKWzTQlsPLLjAA== X-RZG-AUTH: ":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cCgYrrBvJaIR9ymoISrfhsHWODCRPggeTRCTeK" Received: from archlinux.fritz.box by smtp.strato.de (RZmta 51.3.0 AUTH) with ESMTPSA id z34f8113METpRL7 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 22 Apr 2025 16:29:51 +0200 (CEST) From: Jaslo Ziska To: libcamera-devel@lists.libcamera.org Cc: Jaslo Ziska Subject: [PATCH 2/3] gstreamer: Add support for read- and write-only controls Date: Tue, 22 Apr 2025 16:25:20 +0200 Message-ID: <20250422142903.14742-3-jaslo@ziska.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250422142903.14742-1-jaslo@ziska.de> References: <20250422142903.14742-1-jaslo@ziska.de> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Jaslo Ziska Reviewed-by: Nicolas Dufresne --- src/gstreamer/gstlibcamera-controls.cpp.in | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/gstlibcamera-controls.cpp.in index 28604a3c..b38038ca 100644 --- a/src/gstreamer/gstlibcamera-controls.cpp.in +++ b/src/gstreamer/gstlibcamera-controls.cpp.in @@ -126,7 +126,13 @@ g_param_spec_{{ ctrl.gtype }}( {%- endif %} (GParamFlags) (GST_PARAM_CONDITIONALLY_AVAILABLE | GST_PARAM_CONTROLLABLE | +{%- if ctrl.direction == 'ControlId::Direction::In' %} + G_PARAM_WRITABLE | +{%- elif ctrl.direction == 'ControlId::Direction::Out' %} + G_PARAM_READABLE | +{%- else %} G_PARAM_READWRITE | +{%- endif %} G_PARAM_STATIC_STRINGS) ) {%- endset %} @@ -142,7 +148,13 @@ g_param_spec_{{ ctrl.gtype }}( {{ spec|indent_str('\t\t\t') }}, (GParamFlags) (GST_PARAM_CONDITIONALLY_AVAILABLE | GST_PARAM_CONTROLLABLE | +{%- if ctrl.direction == 'ControlId::Direction::In' %} + G_PARAM_WRITABLE | +{%- elif ctrl.direction == 'ControlId::Direction::Out' %} + G_PARAM_READABLE | +{%- else %} G_PARAM_READWRITE | +{%- endif %} G_PARAM_STATIC_STRINGS) ) {%- else %}