From patchwork Mon Apr 21 15:51:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23201 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7B221C331E for ; Mon, 21 Apr 2025 15:51:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 255DD68AD8; Mon, 21 Apr 2025 17:51:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="apEizoY3"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ACA2A68AC3 for ; Mon, 21 Apr 2025 17:51:14 +0200 (CEST) Received: from pb-laptop.local (185.221.143.16.nat.pool.zt.hu [185.221.143.16]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AF966D5 for ; Mon, 21 Apr 2025 17:49:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1745250548; bh=qilTFUMYiT0u0a0gF9NFLhvjVqE9yf0FqqheIQRhkG0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=apEizoY3cfHXpNnztj4L7cgsvv/q8jDCQA5whoWKo25LQKn8krZU69yemJzz0oDRj kk/jRbN4hZ2HNi4ZTnxsfVfM8xeaJPMJd0Yb/CjOn+W+As1d/jts0DdIX1JC5soZh5 T8PtbotH034K8Iwo2VKjmkm9U5HEYcJbt6ATf7hE= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v1 5/5] apps: cam: sdl_sink: Support `{RGB,BGR}888` Date: Mon, 21 Apr 2025 17:51:09 +0200 Message-ID: <20250421155109.175930-6-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250421155109.175930-1-barnabas.pocze@ideasonboard.com> References: <20250421155109.175930-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These two formats map to `SDL_PIXELFORMAT_{RGB,BGR}24`, respectively; use the generic `SDLTexture1Plane` to handle them. Signed-off-by: Barnabás Pőcze --- src/apps/cam/sdl_sink.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/apps/cam/sdl_sink.cpp b/src/apps/cam/sdl_sink.cpp index b295675dc..51c8cfb52 100644 --- a/src/apps/cam/sdl_sink.cpp +++ b/src/apps/cam/sdl_sink.cpp @@ -77,6 +77,12 @@ int SDLSink::configure(const libcamera::CameraConfiguration &config) case libcamera::formats::YUYV: texture_ = std::make_unique(rect_, SDL_PIXELFORMAT_YUY2, cfg.stride); break; + case libcamera::formats::RGB888: + texture_ = std::make_unique(rect_, SDL_PIXELFORMAT_RGB24, cfg.stride); + break; + case libcamera::formats::BGR888: + texture_ = std::make_unique(rect_, SDL_PIXELFORMAT_BGR24, cfg.stride); + break; default: std::cerr << "Unsupported pixel format " << cfg.pixelFormat.toString() << std::endl;