From patchwork Thu Apr 17 11:35:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23185 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A8C62C3213 for ; Thu, 17 Apr 2025 11:35:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9948A68ACA; Thu, 17 Apr 2025 13:35:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WdJ04FJ5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A94EF68AB8 for ; Thu, 17 Apr 2025 13:35:43 +0200 (CEST) Received: from pb-laptop.local (185.221.143.16.nat.pool.zt.hu [185.221.143.16]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 071037E0 for ; Thu, 17 Apr 2025 13:33:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1744889620; bh=fAkcG0jCLSKsiKuClGSPd6cxE1FWezwBJPnmbcYn0To=; h=From:To:Subject:Date:In-Reply-To:References:From; b=WdJ04FJ52pzVt7nuRsc9y+i+5guLQwbfJeYh9UkTEhUIXjSJI0Dxbtx8yUEyH2vaf nZrXHiiH4HnX7V7eJBJeweJ2SeCksFfSWScFwHGZf8qP+AO67u7jvYYAi1Q1BHD9JE NmKTFhB1Ud0HXlXk5lIgQTpSPup6fGMucftotOs4= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 2/3] libcamera: controls: Implement move ctor/assignment Date: Thu, 17 Apr 2025 13:35:38 +0200 Message-ID: <20250417113539.1137936-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417113539.1137936-1-barnabas.pocze@ideasonboard.com> References: <20250417113539.1137936-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Implement a move constructor and move assignment operator for `ControlValue`. The `ControlValue` type already has an "empty" state that it used when creating a default constructed `ControlValue`, so have the moved-from instance return to that state after move construction/assignment. This is useful, for example, for `std::vector` as most implementations will use the copy constructor when reallocating if no nothrow move constructor is available. Having a nothrow move constructor avoids the extra copies. It is also useful when using temporaries of `ControlValue` with other containers such as `std::optional`, and it also makes `ControlInfo` "cheaply" move constructible/assignable. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- include/libcamera/controls.h | 28 ++++++++++++++++++++++++++++ src/libcamera/controls.cpp | 17 +++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h index 1dc6ccffa..86245e7a9 100644 --- a/include/libcamera/controls.h +++ b/include/libcamera/controls.h @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -165,6 +166,33 @@ public: ControlValue(const ControlValue &other); ControlValue &operator=(const ControlValue &other); + ControlValue(ControlValue &&other) noexcept + : type_(other.type_), + isArray_(std::exchange(other.isArray_, false)), + numElements_(other.numElements_), + storage_(std::exchange(other.storage_, {})) + { + other.type_ = ControlTypeNone; + other.numElements_ = 0; + } + + ControlValue &operator=(ControlValue &&other) noexcept + { + if (this != &other) { + release(); + + type_ = other.type_; + isArray_ = std::exchange(other.isArray_, false); + numElements_ = other.numElements_; + storage_ = std::exchange(other.storage_, {}); + + other.type_ = ControlTypeNone; + other.numElements_ = 0; + } + + return *this; + } + ControlType type() const { return type_; } bool isNone() const { return type_ == ControlTypeNone; } bool isArray() const { return isArray_; } diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp index d384e1ef7..885287e71 100644 --- a/src/libcamera/controls.cpp +++ b/src/libcamera/controls.cpp @@ -155,6 +155,23 @@ ControlValue &ControlValue::operator=(const ControlValue &other) return *this; } +/** + * \fn ControlValue::ControlValue(ControlValue &&other) noexcept + * \brief Move constructor for ControlValue + * \param[in] other The ControlValue object to move from + * + * Move constructs a ControlValue instance from \a other. After this opreation + * \a other will be in the same state as a default constructed ControlValue instance. + */ + +/** + * \fn ControlValue &ControlValue::operator=(ControlValue &&other) noexcept + * \brief Move assignment operator for ControlValue + * \param[in] other The ControlValue object to move from + * + * \sa ControlValue::ControlValue(ControlValue &&other) + */ + /** * \fn ControlValue::type() * \brief Retrieve the data type of the value