From patchwork Tue Apr 15 15:48:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23181 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AA1F2C3213 for ; Tue, 15 Apr 2025 15:48:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CA2FC68AB9; Tue, 15 Apr 2025 17:48:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PQ4pWxbM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DCE98627EF for ; Tue, 15 Apr 2025 17:48:21 +0200 (CEST) Received: from pb-laptop.local (185.182.215.138.nat.pool.zt.hu [185.182.215.138]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FE57725 for ; Tue, 15 Apr 2025 17:46:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1744731979; bh=DobXLS0+Mp0vDLiEIZHe9C8n9PiIrwF3gHhqlIpEuDU=; h=From:To:Subject:Date:From; b=PQ4pWxbMyXFhjSubyN/Unpm9UIgrDJOz2/TNbh8lsrTb25f0xcb+vMtNCMUq8Puee IbdJwunqpy0oVy7KJ0LCGMbQvs7K85yWoe/EfER+EptDQ9NLpySmRziZj1E2QMDZhG IEug2rHxNlPsWPmCldfb8tLMB6AxrzAgC2/qifhw= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] utils: ipc: Do not duplicate signals in proxy object Date: Tue, 15 Apr 2025 17:48:18 +0200 Message-ID: <20250415154818.398689-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The specific proxy type (see `module_ipa_proxy.h.tmpl`) inherits `IPAProxy`, the specific interface type, and `Object`. The interface type already provides public definitions of the necessary `Signal<>` objects (see `module_ipa_interface.h.tmpl`), so do not duplicate them. Signed-off-by: Barnabás Pőcze Reviewed-by: Paul Elder --- .../libcamera_templates/module_ipa_proxy.h.tmpl | 9 --------- 1 file changed, 9 deletions(-) diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl index e213b18a0..a0312a7c1 100644 --- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl +++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl @@ -44,15 +44,6 @@ public: {{proxy_funcs.func_sig(proxy_name, method, "", false, true)|indent(8, true)}}; {% endfor %} -{%- for method in interface_event.methods %} - Signal< -{%- for param in method.parameters -%} - {{"const " if not param|is_pod}}{{param|name}}{{" &" if not param|is_pod and not param|is_enum}} - {{- ", " if not loop.last}} -{%- endfor -%} -> {{method.mojom_name}}; -{% endfor %} - private: void recvMessage(const IPCMessage &data);