From patchwork Fri Nov 8 20:54:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 2317 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E7FFE60180 for ; Fri, 8 Nov 2019 21:54:29 +0100 (CET) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BD2F2D1 for ; Fri, 8 Nov 2019 21:54:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1573246469; bh=8Wn8OxFo8oHZj/VGcpU2ja0SkDrF2F/Wtw9rxZAG9QY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=q8iK00Lv9mWWBNWcyx6hsK8XPH7cgvmb+MeCFrsXq4kwGfS4Q/y3+/R55KYd6lZZS b93YOJz9PJ+k58n62XBzyERB9Dw5gwCBEHz/SX/up3yLASHX6bP9pTUwk9D+lHxMGx Dl5XVlTVW2csO4xnq085EN1XL0JMOL220V4sHdNc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 8 Nov 2019 22:54:06 +0200 Message-Id: <20191108205409.18845-22-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191108205409.18845-1-laurent.pinchart@ideasonboard.com> References: <20191108205409.18845-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 21/24] ipa: Declare the ipaCreate() function prototype X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 20:54:30 -0000 IPA modules have to implement a public ipaCreate() function, but its prototype isn't declared in any header file. This allows for modules to get the prototype wrong without being warned by the compiler. Fix it. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Niklas Söderlund --- include/ipa/ipa_interface.h | 2 ++ src/libcamera/ipa_interface.cpp | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h index 3a423e37671f..92f1aac50b85 100644 --- a/include/ipa/ipa_interface.h +++ b/include/ipa/ipa_interface.h @@ -80,6 +80,8 @@ struct ipa_context_ops { const struct ipa_operation_data *data); }; +struct ipa_context *ipaCreate(); + #ifdef __cplusplus } diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp index 89fce0e8347f..cb2767a04711 100644 --- a/src/libcamera/ipa_interface.cpp +++ b/src/libcamera/ipa_interface.cpp @@ -261,6 +261,16 @@ * \sa libcamera::IPAInterface::processEvent() */ +/** + * \fn ipaCreate() + * \brief Entry point to the IPA modules + * + * This function is the entry point to the IPA modules. It is implemented by + * every IPA module, and called by libcamera to create a new IPA context. + * + * \return A newly created IPA context + */ + namespace libcamera { /**