From patchwork Fri Apr 11 12:36:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23164 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5A28DC327D for ; Fri, 11 Apr 2025 12:37:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 108BF68AB7; Fri, 11 Apr 2025 14:37:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cc1WT0hL"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B963C68AB4 for ; Fri, 11 Apr 2025 14:37:06 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:5b21:2ad5:1023:7179]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 69502667; Fri, 11 Apr 2025 14:35:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1744374907; bh=SeLXgg9s3PLEqT2OXDoSLbE6kZAMyEtled4XP+VsL7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cc1WT0hLCD7HqjHkQI/iJzJuMIAYKZq8mpn8yTlKK4XPL8euAr4ChrICXJCECPPSD ELCMf39DIecPAodG4bK3O3Edqg+rzoLIT6guog9QYiWhUV8ICcJK/nsyc/WH+xZocA DpVotJg3RKzjxXC9exw8qe4yysWe9vz/BT11BJjM= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham Subject: [PATCH v2 7/9] pipeline: rkisp1: Add color space information to debug log Date: Fri, 11 Apr 2025 14:36:35 +0200 Message-ID: <20250411123641.2144530-8-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250411123641.2144530-1-stefan.klug@ideasonboard.com> References: <20250411123641.2144530-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not applied correctly. Add the color space to the debug log output to be able to detect that now and later. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham --- Changes in v2: - Collected tag --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 9d7a3bd57ada..2708cecca0b0 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) LOG(RkISP1, Debug) << "ISP output pad configured with " << format - << " crop " << outputCrop; + << " crop " << outputCrop + << " color space " << ColorSpace::toString(format.colorSpace); IPACameraSensorInfo sensorInfo; ret = data->sensor_->sensorInfo(&sensorInfo);