From patchwork Thu Apr 3 15:49:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23126 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 33A7FC327D for ; Thu, 3 Apr 2025 15:50:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E8A8668AA4; Thu, 3 Apr 2025 17:50:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mPaj8Wmy"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5245768A99 for ; Thu, 3 Apr 2025 17:50:05 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:6d9d:9854:3fc1:4bb2]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A895B11E9; Thu, 3 Apr 2025 17:48:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743695291; bh=m6PCB6BkuTeM5Q0Jw/DmKkQLqGea+CVDblqFGnecTOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mPaj8WmyQF7iZy/7Fr7Gyca8I6kaY6rj8L+F66p5h8UhO6imvqgB3TeqO/5Zl/57c PDrPKCX7ru/856IRJ0xz2/vkAVExu0EjJI2WfvCQK8R/YtKbrwrU7gRHjyR76Wos4b JUs2JlheLPSA5gO8RUGY6ZPS139kkKnmcAi0W9UA= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 10/16] ipa: rkisp1: algorithms: awb: Fix wrong colour temperature reporting Date: Thu, 3 Apr 2025 17:49:15 +0200 Message-ID: <20250403154925.382973-11-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250403154925.382973-1-stefan.klug@ideasonboard.com> References: <20250403154925.382973-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In commit b60bd37b1a49 ("ipa: rkisp1: Move calculation of RGB means into own function") the output of the current measured colour temperature as metadata was incorrectly added. Remove it. Fixes: b60bd37b1a49 ("ipa: rkisp1: Move calculation of RGB means into own function") Signed-off-by: Stefan Klug --- Changes in v3: - Added this patch --- src/ipa/rkisp1/algorithms/awb.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index a9759e53f593..79c4c658406d 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -311,9 +311,6 @@ void Awb::process(IPAContext &context, activeState.awb.temperatureK = awbResult.colourTemperature; - /* Metadata shall contain the up to date measurement */ - metadata.set(controls::ColourTemperature, activeState.awb.temperatureK); - /* * Clamp the gain values to the hardware, which expresses gains as Q2.8 * unsigned integer values. Set the minimum just above zero to avoid