From patchwork Thu Apr 3 07:45:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 23114 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6F2F3C3213 for ; Thu, 3 Apr 2025 07:46:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 225E0689AA; Thu, 3 Apr 2025 09:46:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JbaAKXbZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 69FB5689A5 for ; Thu, 3 Apr 2025 09:46:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743666381; x=1775202381; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xC5bNifgf4XOGco3L6/+Hy/vrlKFV/6DHm6pP/6liR8=; b=JbaAKXbZh86hIjFg2vlDWqFA3kzcqiUeSWx+gfqKUHQW4CzK9WDO8W1R poXjCf+rg5AGjNhA+ODXCKOQYSVq5p6CeQ4m7gy8nZkXNEwLD+WKZlhme J6g1+OOht8FBo793n49p2N2bSvtxYKDU6g19dokTV9bGPIe2Cek7oHNnj BkdLzvcILnsQdYZQtDKwdR6K7ocusEv8sPeX+qL/JA13I/mpcwGt15vnl xUrovbAteyr5PQ+P2o+ChkrfEFbG/Ru7IdPGHUiNeqTsk5ObEbYv1KJmG avLskL5mB+Vyw3VEDX2EoKtQzwUHF4C4dv28+x2PC/EAj8nmWkLKSVw1l g==; X-CSE-ConnectionGUID: KvhxXeyMSKOOMnFEPqghbA== X-CSE-MsgGUID: 9rbI+54YRp2rCPhhEPHXuA== X-IronPort-AV: E=McAfee;i="6700,10204,11392"; a="48721725" X-IronPort-AV: E=Sophos;i="6.15,184,1739865600"; d="scan'208";a="48721725" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2025 00:46:20 -0700 X-CSE-ConnectionGUID: HZkD2GQIRTWPjjqjmkhIRw== X-CSE-MsgGUID: 9jsrgDzRSaqTkaH3DHdoOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,184,1739865600"; d="scan'208";a="164159720" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.246.8.237]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2025 00:46:18 -0700 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Hans de Goede , Laurent Pinchart , Kieran Bingham , Sakari Ailus , Stefan Klug Subject: [PATCH v7 5/5] pipeline: simple: Reset delayedCtrls at start Date: Thu, 3 Apr 2025 09:45:51 +0200 Message-Id: <20250403074551.263496-6-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250403074551.263496-1-stanislaw.gruszka@linux.intel.com> References: <20250403074551.263496-1-stanislaw.gruszka@linux.intel.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Similar like in other pipelines (IPU3, rpi) avoid using stale values of DelayedControls class when the same camera is started second time. Reviewed-by: Kieran Bingham Reviewed-by: Stefan Klug Co-developed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Stanislaw Gruszka --- src/libcamera/pipeline/simple/simple.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 262192b849e2..0432e591aa8d 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1462,6 +1462,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL video->bufferReady.connect(data, &SimpleCameraData::imageBufferReady); + data->delayedCtrls_->reset(); if (frameStartEmitter) { ret = frameStartEmitter->setFrameStartEnabled(true); if (ret) {