From patchwork Wed Apr 2 15:11:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23108 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BBB94C323E for ; Wed, 2 Apr 2025 15:12:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7A0BB6897E; Wed, 2 Apr 2025 17:12:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZLHvMShM"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66AD368979 for ; Wed, 2 Apr 2025 17:12:06 +0200 (CEST) Received: from pb-laptop.local (185.221.143.221.nat.pool.zt.hu [185.221.143.221]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E533415; Wed, 2 Apr 2025 17:10:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743606613; bh=mbx8WffDmmCBbsC61lI/P9WmgQsIeOpg0hL0daO3/Oc=; h=From:To:Cc:Subject:Date:From; b=ZLHvMShMJutOm7Te0GaalSlZfaBG/6esZMJ/xh+9/lBfI7z8VL1MD0JtW6y7LUSAz YIMJYCWPjwhh9dksmK1SeO5g7B63nxgBpi2zAxMOnpeAJykatsuzpi27ccOwB6aONG R2AIh3OH4ptMo9F8HapMwSlX7tJD0quFtedOTuEs= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable control as available Date: Wed, 2 Apr 2025 17:11:58 +0200 Message-ID: <20250402151158.968707-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The `AeEnable` control is handled by the `Camera` class directly, but it still has to be added because `ControlInfoMap`s are not easily modifiable. See 338ba00e7abfe8 ("ipa: rkisp1: agc: Report new AeEnable control as available") for more details and a similar change in rkisp1. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- changes in v2: * only report control if it can actually do something v1: https://patchwork.libcamera.org/patch/23106/ --- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++ 1 file changed, 5 insertions(+) -- 2.49.0 diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index 5adc89fdb..a7e0fcfbc 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -590,6 +590,11 @@ int UVCCameraData::init(MediaDevice *media) addControl(cid, info, &ctrls); } + if (autoExposureMode_ && manualExposureMode_) { + /* \todo Move this to the Camera class */ + ctrls[&controls::AeEnable] = ControlInfo(false, true, true); + } + controlInfo_ = ControlInfoMap(std::move(ctrls), controls::controls); /*