From patchwork Wed Apr 2 11:49:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 23106 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AC85BC3213 for ; Wed, 2 Apr 2025 11:49:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 888E86898E; Wed, 2 Apr 2025 13:49:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r9Mg9tRK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3755E68979 for ; Wed, 2 Apr 2025 13:49:39 +0200 (CEST) Received: from pb-laptop.local (185.221.143.221.nat.pool.zt.hu [185.221.143.221]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EBB06A2 for ; Wed, 2 Apr 2025 13:47:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743594466; bh=xLjGc9R2xa/DzVB+RJAhqX63Z7KY50oUu0tj8SzXKXY=; h=From:To:Subject:Date:From; b=r9Mg9tRKNBgedgTNyKmI68u7nZ1J30uFHvhTRLEmiIvlCVxduZiPJFlwZbbVDavkL Za2Tr649Sm9+oQtMBfo/rdc0ToluOwitA0GYHBLUpvMdEJipJsjWdk9pg6nFWHJw+1 XR5c8Yn9xzW8m1sNT8SIXgsCDixpyE4igx1CVdfI= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1] libcamera: pipeline: uvcvideo: Report new AeEnable control as available Date: Wed, 2 Apr 2025 13:49:28 +0200 Message-ID: <20250402114928.937042-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The `AeEnable` control is handled by the `Camera` class directly, but it still has to be added because `ControlInfoMap`s are not easily modifiable. See 338ba00e7abfe8 ("ipa: rkisp1: agc: Report new AeEnable control as available") for more details and a similar change in rkisp1. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index 5adc89fdb..ab180e820 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -583,6 +583,9 @@ int UVCCameraData::init(MediaDevice *media) /* Initialise the supported controls. */ ControlInfoMap::Map ctrls; + /* \todo Move this to the Camera class */ + ctrls[&controls::AeEnable] = ControlInfo(false, true, true); + for (const auto &ctrl : video_->controls()) { uint32_t cid = ctrl.first->id(); const ControlInfo &info = ctrl.second;