From patchwork Wed Apr 2 07:39:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 23103 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 44BF8C3213 for ; Wed, 2 Apr 2025 07:39:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0288268988; Wed, 2 Apr 2025 09:39:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UTM+W09k"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B1E2E6897E for ; Wed, 2 Apr 2025 09:39:33 +0200 (CEST) Received: from neptunite.flets-east.jp (unknown [IPv6:2404:7a81:160:2100:c59e:fbfb:58d5:f44f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DA2D66A2; Wed, 2 Apr 2025 09:37:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743579461; bh=Ma3dIhyFjaPxIkz181zRHR5CC73LPECDwdBvgGDXvhc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UTM+W09kiUc6cX7jCyMbAJgrxoa0Tv5YBGiISORJ6umjpQoMUsgTw8KL0QTVxw0bb DNAEM06wsB4cFsg734awanxKEJ1WMigXpfCsR9ofQRauQLHQ8baip1EYoitfoJf94l zoS/FDgQ+0S4FwSd5AR00RY/Ytaqg9QzJvUAL54o= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham , Umang Jain , Jacopo Mondi , Daniel Scally , Paul Elder Subject: [PATCH v4 1/3] libcamera: media_device: Add helper to return matching entities Date: Wed, 2 Apr 2025 16:39:16 +0900 Message-ID: <20250402073919.183330-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250402073919.183330-1-paul.elder@ideasonboard.com> References: <20250402073919.183330-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Kieran Bingham Provide a helper on the MediaDevice to return a list of all available entities which match a given function in the graph. As a drive by, also fix a whitespace error in the documentation of MediaDevice::setupLink. Signed-off-by: Kieran Bingham Reviewed-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Daniel Scally Signed-off-by: Paul Elder Reviewed-by: Stefan Klug --- include/libcamera/internal/media_device.h | 2 ++ src/libcamera/media_device.cpp | 24 ++++++++++++++++++++++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h index e412d3a0b7e3..b3a48b98d64b 100644 --- a/include/libcamera/internal/media_device.h +++ b/include/libcamera/internal/media_device.h @@ -55,6 +55,8 @@ public: Signal<> disconnected; + std::vector locateEntities(unsigned int function); + protected: std::string logPrefix() const override; diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index 75abd91d736a..353f34a81eca 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -794,7 +794,7 @@ void MediaDevice::fixupEntityFlags(struct media_v2_entity *entity) * low-level link setup as it performs no checks on the validity of the \a * flags, and assumes that the supplied \a flags are valid for the link (e.g. * immutable links cannot be disabled). -* + * * \sa MediaLink::setEnabled(bool enable) * * \return 0 on success or a negative error code otherwise @@ -829,4 +829,26 @@ int MediaDevice::setupLink(const MediaLink *link, unsigned int flags) return 0; } +/** + * \brief Identify all entities of a common function in the MediaDevice + * \param[in] function The entity function to search for + * + * Search all entities within the graph of the MediaDevice and return + * a vector of those which match the given function. + * + * \return A vector of matching entities + */ +std::vector MediaDevice::locateEntities(unsigned int function) +{ + std::vector found; + + /* Gather all the entities matching the function they expose. */ + for (MediaEntity *entity : entities()) { + if (entity->function() == function) + found.push_back(entity); + } + + return found; +} + } /* namespace libcamera */