From patchwork Tue Apr 1 12:36:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23091 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ED12EC3213 for ; Tue, 1 Apr 2025 12:36:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B1A3868992; Tue, 1 Apr 2025 14:36:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NVtYhmM6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E00526898F for ; Tue, 1 Apr 2025 14:36:50 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:14c7:4fcc:495b:719f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AF87D8DB; Tue, 1 Apr 2025 14:34:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743510898; bh=ox6fwJY1Ya93M7EtZYsXdTbgTfh/Y5fhG4FI2/TW//E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NVtYhmM6f0l6CT1b/QQjglpZ11wNbnF+VPkU+udRfwhybL2P9coQEJ0B/1zoDS07k UtPxWJlo+RVzI0t/1SDGKFgRiG03wkq5wIcvEZSEnjo13ioNQ7CymD9UQurr4DblSD w6mQQue+OqGqhyzMR9q+FQtKT5T+0G+gjHrCLtug= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham , Laurent Pinchart Subject: [PATCH v2 4/5] test: ipa: libipa: histogram: Add tests for small inter quantile mean ranges Date: Tue, 1 Apr 2025 14:36:12 +0200 Message-ID: <20250401123633.58887-5-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250401123633.58887-1-stefan.klug@ideasonboard.com> References: <20250401123633.58887-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add tests for small inter quantile mean ranges. As these cases fail at the moment, mark the test as should_fail. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- Changes in v2: - Move test patch before fix - Add should_fail - Fix typo in comment --- test/ipa/libipa/histogram.cpp | 4 ++++ test/ipa/libipa/meson.build | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp index 5ce84a61b7da..77ff31a6db0e 100644 --- a/test/ipa/libipa/histogram.cpp +++ b/test/ipa/libipa/histogram.cpp @@ -55,6 +55,10 @@ protected: /* Test interquantile mean that starts and ends in the middle of a bin. */ ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0); + /* Test small ranges at the borders of the histogram. */ + ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1); + ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9); + return TestPass; } }; diff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build index 8c63ebd8e2f7..83c84bd8c227 100644 --- a/test/ipa/libipa/meson.build +++ b/test/ipa/libipa/meson.build @@ -2,7 +2,7 @@ libipa_test = [ {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']}, - {'name': 'histogram', 'sources': ['histogram.cpp']}, + {'name': 'histogram', 'sources': ['histogram.cpp'], 'should_fail': true}, {'name': 'interpolator', 'sources': ['interpolator.cpp']}, ]