From patchwork Tue Apr 1 12:36:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23089 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BEFC4C3213 for ; Tue, 1 Apr 2025 12:36:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 81E246898A; Tue, 1 Apr 2025 14:36:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="U18J/qYK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F264D68986 for ; Tue, 1 Apr 2025 14:36:43 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:14c7:4fcc:495b:719f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D5B668DB; Tue, 1 Apr 2025 14:34:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743510891; bh=GZmB11y+IhtBtTi7bnLPo96lf/dc+fT1pp9i/K/fHhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U18J/qYKdKeUiRPwv5lIaUFKsxXpmpLvbYNyAqcWrIjtRtNu0p4q0AVpTSgcY0myL RNEufyMcQUKKmhO4E/7XoB/GJ/bZIn8XOqE+8mm6YzWNnejdJ1JybvW9sK5CwfvKQj s+hvMBx8taYwua4+W/oPt0UHfAtvdnq8cuAWxlb4= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham , Laurent Pinchart Subject: [PATCH v2 2/5] test: ipa: libipa: histogram: Add tests for quantile() returning a fraction Date: Tue, 1 Apr 2025 14:36:10 +0200 Message-ID: <20250401123633.58887-3-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250401123633.58887-1-stefan.klug@ideasonboard.com> References: <20250401123633.58887-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add tests for quantile() returning a fractional value. These cases will get fixed in the next commit. Therefore mark the test as should_fail. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- Changes in v2: - Move test patch before fix and add should_fail. - Fixed comment - Collected tags --- test/ipa/libipa/histogram.cpp | 9 +++++++++ test/ipa/libipa/meson.build | 5 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp index 312b88b0786b..5ce84a61b7da 100644 --- a/test/ipa/libipa/histogram.cpp +++ b/test/ipa/libipa/histogram.cpp @@ -42,10 +42,19 @@ protected: ASSERT_EQ(hist.quantile(1.0), 2.0); ASSERT_EQ(hist.quantile(0.5), 1.0); + /* Test quantile in the middle of a bin. */ + ASSERT_EQ(hist.quantile(0.75), 1.5); + + /* Test quantile smaller than the smallest histogram step. */ + ASSERT_EQ(hist.quantile(0.001), 0.002); + ASSERT_EQ(hist.interQuantileMean(0.0, 1.0), 1.0); ASSERT_EQ(hist.interQuantileMean(0.0, 0.5), 0.5); ASSERT_EQ(hist.interQuantileMean(0.5, 1.0), 1.5); + /* Test interquantile mean that starts and ends in the middle of a bin. */ + ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0); + return TestPass; } }; diff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build index f094c1593f1b..83c84bd8c227 100644 --- a/test/ipa/libipa/meson.build +++ b/test/ipa/libipa/meson.build @@ -2,7 +2,7 @@ libipa_test = [ {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']}, - {'name': 'histogram', 'sources': ['histogram.cpp']}, + {'name': 'histogram', 'sources': ['histogram.cpp'], 'should_fail': true}, {'name': 'interpolator', 'sources': ['interpolator.cpp']}, ] @@ -14,5 +14,6 @@ foreach test : libipa_test include_directories : [test_includes_internal, '../../../src/ipa/libipa/']) - test(test['name'], exe, suite : 'ipa') + test(test['name'], exe, suite : 'ipa', + should_fail : test.get('should_fail', false)) endforeach