From patchwork Mon Mar 31 14:43:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 23080 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E54A2C3213 for ; Mon, 31 Mar 2025 14:44:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 965CC6899C; Mon, 31 Mar 2025 16:44:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="blYx+tNv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D520168996 for ; Mon, 31 Mar 2025 16:44:15 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F65A725; Mon, 31 Mar 2025 16:42:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743432144; bh=FrkIQwe2uBxEDe8gYFJvxMqx2t8Jfz0qWEy1DpNiwYE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=blYx+tNvaPioGDRCH12FcB/X4I8Jh6BiC5JSQGzlFTkoCSXiQ3tM3TlF7rVkpczKM 6F+CEveg1+/n1FEravHwvPD+LDjN4ExxxVoOECkhVNIQr1uuQRXKvTiWy/4H1s0/xk b959A0dDWPMb4eh3vshSNCpJQ0E6TKAjAjbhrcr0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 7/9] pipeline: rkisp1: Add color space information to debug log Date: Mon, 31 Mar 2025 16:43:46 +0200 Message-ID: <20250331144352.736700-8-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250331144352.736700-1-stefan.klug@ideasonboard.com> References: <20250331144352.736700-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not applied correctly. Add the color space to the debug log output to be able to detect that now and later. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 132ab40fdbf7..bd74b73d1e68 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) LOG(RkISP1, Debug) << "ISP output pad configured with " << format - << " crop " << outputCrop; + << " crop " << outputCrop + << " color space " << ColorSpace::toString(format.colorSpace); IPACameraSensorInfo sensorInfo; ret = data->sensor_->sensorInfo(&sensorInfo);