From patchwork Tue Mar 11 13:01:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 22950 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BD9B1C0F2A for ; Tue, 11 Mar 2025 13:02:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7AECE687FA; Tue, 11 Mar 2025 14:02:02 +0100 (CET) Received: from smtp-bc0b.mail.infomaniak.ch (smtp-bc0b.mail.infomaniak.ch [45.157.188.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 183EE61800 for ; Tue, 11 Mar 2025 14:02:01 +0100 (CET) Received: from smtp-4-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:7:10:40ca:feff:fe05:0]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4ZBv6c5hNYzSjr; Tue, 11 Mar 2025 14:02:00 +0100 (CET) Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4ZBv6c1vHGz2tf; Tue, 11 Mar 2025 14:02:00 +0100 (CET) From: Quentin Schulz Date: Tue, 11 Mar 2025 14:01:47 +0100 Subject: [PATCH] README.rst: remove unnecessary dependency for qcam MIME-Version: 1.0 Message-Id: <20250311-qttools-unneeded-v1-1-834c30be7e7a@cherry.de> X-B4-Tracking: v=1; b=H4sIADo00GcC/x3MTQqAIBBA4avIrBvQsh+6SrSQnGogtNQiiO6et PwW7z0QKTBF6MUDgS6O7F2GKgRMq3ELIdtsKGVZy0opPFLyfot4OkdkyaJuuqqVWivTaMjZHmj m+18O4/t+d7B9B2IAAAA= X-Change-ID: 20250311-qttools-unneeded-468370441a64 To: libcamera-devel@lists.libcamera.org Cc: Quentin Schulz X-Mailer: b4 0.14.2 X-Infomaniak-Routing: alpha X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Quentin Schulz The introducing commit (dff416a84b78 ("README: Add missing package for Qt5 tools"); for Qt 5 originally) stated that without the dependency we would get the following messages: Program /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease found: NO Program lrelease-qt5 found: NO Program lrelease found: NO found but need: '== 5.14.2' That is still the case but this actually is neither breaking the build nor is it doing anything to the outcome of the build as qcam is bit to bit identical with and without that package. Therefore, let's not mislead users to install an unnecessary package. Signed-off-by: Quentin Schulz Reviewed-by: Kieran Bingham --- This was tested within a debian:bookworm container with and without the package, checked out both at master and introducing commit. qcam is bit to bit identical in both cases. --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 39419ce431dbd4f34d8772bd31bb7f44a3534f86 change-id: 20250311-qttools-unneeded-468370441a64 Best regards, diff --git a/README.rst b/README.rst index ae5126e25542a37d0c50287399486c56d2888af8..9dfef7eadb4640f77c28f82d42fadd54aa025641 100644 --- a/README.rst +++ b/README.rst @@ -85,7 +85,7 @@ for cam: [optional] - libsdl2-dev: Enables the SDL sink for qcam: [optional] - libtiff-dev qt6-base-dev qt6-tools-dev-tools + libtiff-dev qt6-base-dev for tracing with lttng: [optional] liblttng-ust-dev python3-jinja2 lttng-tools