From patchwork Wed Mar 5 13:52:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 22930 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 53119C3257 for ; Wed, 5 Mar 2025 13:53:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 09A4768920; Wed, 5 Mar 2025 14:53:29 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gEdvvQux"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CD3A6890C for ; Wed, 5 Mar 2025 14:53:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741182807; x=1772718807; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=90F0usb0Gl3r9ryM8lhKN64VSuwrkfvSPBXQJEicPuk=; b=gEdvvQuxMZuKPbva1rudHPJsr+NHaQnwcs0VnhfjEMWPesYiidBWujLd Zsbmo6djax+R2D67u9qFSS8BewNbxwuUmdFBAYgFAG44khIJ+44jN+QRb vFmEt48kUTJebt1+LVjrGX29A8GZk2463BZMPDwLY+2GNm3lDQjf/QxTw Azqvy4GD1m1GcT7mX1peFe1uXDftwFPbxTJpJu8Cmj1GkLTZInkbE29qC RmLvPo2vaIyk2a3Db2UuF36tkHYoxr+1sQqyiX9RjBoJGdkh0jvGkIKpo bIA4R69BDJS41unNkilr0imasZZqMW8QadrdZcWJViu7/X9MVvIYeW+xs A==; X-CSE-ConnectionGUID: 3V0hcVEIS4Sjl7SzK+nL4g== X-CSE-MsgGUID: K+iuTSanThi9o7w3SGf2ng== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="53134801" X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="53134801" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:27 -0800 X-CSE-ConnectionGUID: T+MviJAvQ9+H42VXWGfHaA== X-CSE-MsgGUID: 5NP7lTviSFO4RpOQPtTMRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="123735829" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.112.97]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 05:53:24 -0800 From: Stanislaw Gruszka To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , Naushir Patuck , Sakari Ailus , Hans de Goede Subject: [PATCH v6 5/5] pipeline: simple: Reset delayedCtrls at start. Date: Wed, 5 Mar 2025 14:52:56 +0100 Message-Id: <20250305135256.801351-6-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305135256.801351-1-stanislaw.gruszka@linux.intel.com> References: <20250305135256.801351-1-stanislaw.gruszka@linux.intel.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Similar like in other pipelines (IPU3, rpi) avoid using stale values of DelayedControls class when the same camera is started second time. Co-developed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Stanislaw Gruszka Reviewed-by: Stefan Klug Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/simple/simple.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 58aa3dba..659b1123 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1376,6 +1376,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] const ControlL video->bufferReady.connect(data, &SimpleCameraData::imageBufferReady); + data->delayedCtrls_->reset(); if (frameStartEmitter) { ret = frameStartEmitter->setFrameStartEnabled(true); if (ret) {