From patchwork Fri Feb 28 12:55:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22897 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 26C84C3259 for ; Fri, 28 Feb 2025 12:56:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CF9CD68778; Fri, 28 Feb 2025 13:56:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JkQ64A93"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D78AF68773 for ; Fri, 28 Feb 2025 13:56:08 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a7e:b81b:5754:579]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 65BD2606; Fri, 28 Feb 2025 13:54:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740747279; bh=ZfQwpR4YgcnBKrll+Dx1CYW9WaEfbVgH0MpFz58T2T8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JkQ64A93K3Stb9MlWqIXwsQxNOqzdkypcYyccb6+nbgKax16pokBvsNzVKhdhYY1s KsKZqg3u+JVcfuPqTmhpagfVNmBq/0N+koUnogaTZobd2FowulRuiTJy5y2qu1Yjp2 h/wYR5nPxDU+VEgnlvJUmJop2qT5uh0iN5k5tXvM= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 1/3] ipa: rkisp1: Add debug log for the sensor controls being set Date: Fri, 28 Feb 2025 13:55:53 +0100 Message-ID: <20250228125600.3241397-2-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250228125600.3241397-1-stefan.klug@ideasonboard.com> References: <20250228125600.3241397-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In the algorithms a lot of information get's logged in debug log level, but there is no place where the values sent to the sensor get logged. Add such a log message. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/rkisp1/rkisp1.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 7547d2f274f4..5f1583e8219b 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -455,6 +455,11 @@ void IPARkISP1::setControls(unsigned int frame) uint32_t gain = context_.camHelper->gainCode(frameContext.agc.gain); uint32_t vblank = frameContext.agc.vblank; + LOG(IPARkISP1, Debug) << "Set controls frame " << frame + << ": exposure " << exposure + << ", gain " << frameContext.agc.gain + << ", vblank " << vblank; + ControlList ctrls(sensorControls_); ctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure)); ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain));