From patchwork Sun Feb 23 23:04:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22837 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 58E95BDB13 for ; Sun, 23 Feb 2025 23:05:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5D1D1686E7; Mon, 24 Feb 2025 00:05:01 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fuzn8KJ9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FFF9686DC for ; Mon, 24 Feb 2025 00:04:42 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A566E353 for ; Mon, 24 Feb 2025 00:03:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740351795; bh=Xclq0HdpXI5FySBzgwvTOxiIL/YEDzYC29rX0Lw+v2Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=fuzn8KJ9OWwwiAT61UNZEPfhF5YW0l0OUMgJt9haXaYtZxErWW7jdtExYgDAg/gNi GBZ0Nq0yZDxwCUm547oAq3d0goNNY+NXw0i6U4Q2DUiupb0/Ay/SMZjJNYNLZCU8Lj j0kUWs42Mhbm7CtvGgqcfjrFXqct8eFni4lkECtM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 15/15] libcamera: Drop spurious colon after doxygen \todo directive Date: Mon, 24 Feb 2025 01:04:03 +0200 Message-ID: <20250223230403.1226-16-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> References: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The doxygen \todo directive doesn't need to be followed by a colon. Drop it. While at it, turn one 'todo:' into '\todo'. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/libipa/awb_bayes.cpp | 5 +++-- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- src/libcamera/pipeline/virtual/config_parser.cpp | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp index d2869610a25b..c3d05e7e3413 100644 --- a/src/ipa/libipa/awb_bayes.cpp +++ b/src/ipa/libipa/awb_bayes.cpp @@ -26,7 +26,8 @@ * * This implementation is based on the initial implementation done by * RaspberryPi. - * \todo: Documentation + * + * \todo Documentation * * \todo Not all the features implemented by RaspberryPi were ported over to * this algorithm because they either rely on hardware features not generally @@ -272,7 +273,7 @@ void AwbBayes::handleControls(const ControlList &controls) RGB AwbBayes::gainsFromColourTemperature(double colourTemperature) { /* - * \todo: In the RaspberryPi code, the ct curve was interpolated in + * \todo In the RaspberryPi code, the ct curve was interpolated in * the white point space (1/x) not in gains space. This feels counter * intuitive, as the gains are in linear space. But I can't prove it. */ diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index 3c2864fd181c..52b57ab4e3b6 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -176,7 +176,7 @@ void Awb::queueRequest(IPAContext &context, awb.gains.manual.r() = (*colourGains)[0]; awb.gains.manual.b() = (*colourGains)[1]; /* - * \todo: Colour temperature reported in metadata is now + * \todo Colour temperature reported in metadata is now * incorrect, as we can't deduce the temperature from the gains. * This will be fixed with the bayes AWB algorithm. */ diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp index 566f18ced51c..ee05b798fded 100644 --- a/src/libcamera/converter/converter_v4l2_m2m.cpp +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp @@ -738,7 +738,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input, } /* - * \todo: This should be extended to include Feature::Flag to denote + * \todo This should be extended to include Feature::Flag to denote * what each converter supports feature-wise. */ static std::initializer_list compatibles = { diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 5abd6b200e83..a05e11fccf8d 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1615,7 +1615,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink) isp_->frameStart.connect(data->delayedCtrls_.get(), &DelayedControls::applyControls); - /* \todo: Init properties. */ + /* \todo Init properties. */ if (!registerMaliCamera(std::move(data), sensor->name())) return false; diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp index 0cbfe39bf2f0..1e009946d53b 100644 --- a/src/libcamera/pipeline/virtual/config_parser.cpp +++ b/src/libcamera/pipeline/virtual/config_parser.cpp @@ -54,7 +54,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe) data->config_.id = cameraId; ControlInfoMap::Map controls; - /* todo: Check which resolution's frame rate to be reported */ + /* \todo Check which resolution's frame rate to be reported */ controls[&controls::FrameDurationLimits] = ControlInfo(1000000 / data->config_.resolutions[0].frameRates[1], 1000000 / data->config_.resolutions[0].frameRates[0]);