From patchwork Sun Feb 23 23:04:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22834 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1CD82BDB13 for ; Sun, 23 Feb 2025 23:04:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 98614686E6; Mon, 24 Feb 2025 00:04:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YVKYSJdP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AB10B686D8 for ; Mon, 24 Feb 2025 00:04:37 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98F36353 for ; Mon, 24 Feb 2025 00:03:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740351791; bh=0lUwjKUJURJnM9Bp1HfhoCWA9Gq4AYqXqbRVXSNf6es=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YVKYSJdPEYble8stGyXg09fHE92N/9NhFl4WguMStNqlcN4zhGh5qOIf0ker8RtrV RfgpP4DggwC7ni9UI8ycSOFm1E2zbhUzp3DPKhr5vR2JO1SS6AzvoTBG0TzLkaXhKD hL1/RId9g41lFIUWO89BJtG1CHbGrvw8xmK2qMOA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 12/15] libipa: awb_grey: Minor comment fixes Date: Mon, 24 Feb 2025 01:04:00 +0200 Message-ID: <20250223230403.1226-13-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> References: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix the top-level file description to mention the file contains an AWB grey world implementation, not a base class, and fix a grammar mistake in a documentation block. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/libipa/awb_grey.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp index 0e6c5220c393..d3d2132b8869 100644 --- a/src/ipa/libipa/awb_grey.cpp +++ b/src/ipa/libipa/awb_grey.cpp @@ -2,7 +2,7 @@ /* * Copyright (C) 2024 Ideas on Board Oy * - * Base class for grey world AWB algorithm + * Implementation of grey world AWB algorithm */ #include "awb_grey.h" @@ -61,10 +61,10 @@ int AwbGrey::init(const YamlObject &tuningData) * \param[in] stats The statistics to use for the calculation * \param[in] lux The lux value of the scene * - * Estimates the colour temperature based on the colours::estimateCCT function. - * The gains are calculated purely based on the RGB means provided by the \a - * stats. The colour temperature is not taken into account when calculating the - * gains. + * The colour temperature is estimated based on the colours::estimateCCT() + * function. The gains are calculated purely based on the RGB means provided by + * the \a stats. The colour temperature is not taken into account when + * calculating the gains. * * The \a lux parameter is not used in this algorithm. *