From patchwork Sun Feb 23 23:03:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22831 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 01AB6BDB13 for ; Sun, 23 Feb 2025 23:04:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 689A5686DF; Mon, 24 Feb 2025 00:04:48 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="tGP1fQcJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E05CE686CD for ; Mon, 24 Feb 2025 00:04:32 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD98B353 for ; Mon, 24 Feb 2025 00:03:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740351787; bh=iIyFbfWwBtq4D8Iz6sqmFu0J2dc23wVVy1rSX9npdok=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tGP1fQcJBStW75Lzgq5WGNQ8ge1BDh76nrqUcBfI5n6ic09HG6co/6bejyLS7iNFE Xka84gcOoPZe/cVFB2VVr2bqk0fnzwiIZL03R3LoeqAYz/1trJA2p3erKBwF6Rtioc n2PQyTXrWLkUsHn6DrM1BY8Af58p9i+FZqwj0P7o= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 09/15] libipa: awb: Make controls_ member variable private Date: Mon, 24 Feb 2025 01:03:57 +0200 Message-ID: <20250223230403.1226-10-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> References: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The AwbAlgorithm::controls_ member variable doesn't need to be accessed by derived classes. Turn it from public to private. Signed-off-by: Laurent Pinchart --- src/ipa/libipa/awb.cpp | 5 ----- src/ipa/libipa/awb.h | 4 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp index 925fac232709..04cf2d55ed00 100644 --- a/src/ipa/libipa/awb.cpp +++ b/src/ipa/libipa/awb.cpp @@ -249,11 +249,6 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData, * \brief The highest valid colour temperature of that mode */ -/** - * \var AwbAlgorithm::controls_ - * \brief Controls info map for the controls provided by the algorithm - */ - /** * \var AwbAlgorithm::modes_ * \brief Map of all configured modes diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h index a86581adf43e..36c05c37f5e9 100644 --- a/src/ipa/libipa/awb.h +++ b/src/ipa/libipa/awb.h @@ -54,8 +54,10 @@ protected: double ctLo; }; - ControlInfoMap::Map controls_; std::map modes_; + +private: + ControlInfoMap::Map controls_; }; } /* namespace ipa */