From patchwork Sun Feb 23 23:03:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22830 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 16D23BDB13 for ; Sun, 23 Feb 2025 23:04:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5B6B7686E0; Mon, 24 Feb 2025 00:04:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ofsPN9ln"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45A9A686C9 for ; Mon, 24 Feb 2025 00:04:31 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36168353 for ; Mon, 24 Feb 2025 00:03:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740351785; bh=L9XFMcrCWCCN/hx61fGcLqpx9JIITIUXcRntuBjp2ZQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ofsPN9lnVoJdrN2eo1bYEF73TImkoTXQeD6wjflYmxyKSpiaLBnXOQH8d3/SkkFep OTJGt12V1Lp0zp9Rxx9BDvCIVfTXIvbFDjp7iXOHp1qKcBccuGVW4AsHw6b5cx1cnC VuiUaylG04mHfrB8SZRMAGO2HV1a7og2m3jsVc74= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 08/15] libipa: awb: Rename AwbStats::getRGBMeans() to rgbMeans() Date: Mon, 24 Feb 2025 01:03:56 +0200 Message-ID: <20250223230403.1226-9-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> References: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The convention in libcamera is not to prefix getters with a 'get' prefix. Rename the AwbStats::getRGBMeans() function accordingly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/libipa/awb.cpp | 2 +- src/ipa/libipa/awb.h | 2 +- src/ipa/libipa/awb_grey.cpp | 2 +- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp index 1c4f2330ec6c..925fac232709 100644 --- a/src/ipa/libipa/awb.cpp +++ b/src/ipa/libipa/awb.cpp @@ -65,7 +65,7 @@ namespace ipa { */ /** - * \fn AwbStats::getRGBMeans() + * \fn AwbStats::rgbMeans() * \brief Get RGB means of the statistics * * Fetch the RGB means from the statistics. The values of each channel are diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h index 5c298d3b6f69..a86581adf43e 100644 --- a/src/ipa/libipa/awb.h +++ b/src/ipa/libipa/awb.h @@ -26,7 +26,7 @@ struct AwbResult { struct AwbStats { virtual double computeColourError(const RGB &gains) const = 0; - virtual RGB getRGBMeans() const = 0; + virtual RGB rgbMeans() const = 0; }; class AwbAlgorithm diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp index e979cc4d1a3e..17b8598400e7 100644 --- a/src/ipa/libipa/awb_grey.cpp +++ b/src/ipa/libipa/awb_grey.cpp @@ -73,7 +73,7 @@ int AwbGrey::init(const YamlObject &tuningData) AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] unsigned int lux) { AwbResult result; - auto means = stats.getRGBMeans(); + auto means = stats.rgbMeans(); result.colourTemperature = estimateCCT(means); /* diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index 3d6737df801c..af34b81beb96 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -65,7 +65,7 @@ public: return delta2; } - RGB getRGBMeans() const override + RGB rgbMeans() const override { return rgbMeans_; }