From patchwork Sun Feb 23 23:03:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22824 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 42401BDB13 for ; Sun, 23 Feb 2025 23:04:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4881B686BE; Mon, 24 Feb 2025 00:04:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YN4eedfg"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B6FB686B9 for ; Mon, 24 Feb 2025 00:04:23 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 04E53353 for ; Mon, 24 Feb 2025 00:02:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1740351777; bh=aqU/o2GHgx0rCNkHlr5JhSLOVq5GsF7QQFoFpkbvJKU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=YN4eedfgXohLQxV9LzQyEnPE+rdcEKJvAZPEWEZ7bEwwhnz3aSpVIHaNRADPmx94I qMsqcL9Rh2jA9JVHFtuSaH6gz3ef9FRl39w4RGcMrf/heddmHhoGDJVSXjw7kbAjqS APTHP+5b4gAzvQ4rnqbCf2CsxzPsvx+VGksjOBGA= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 02/15] libipa: awb: Capitalize AWB Date: Mon, 24 Feb 2025 01:03:50 +0200 Message-ID: <20250223230403.1226-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> References: <20250223230403.1226-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" AWB is an abbreviation, capitalize it in comments and log messages for consistency. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/libipa/awb.cpp | 14 +++++++------- src/ipa/libipa/awb_grey.cpp | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp index 2e78a4665509..dc672f129c4a 100644 --- a/src/ipa/libipa/awb.cpp +++ b/src/ipa/libipa/awb.cpp @@ -24,7 +24,7 @@ namespace ipa { /** * \class AwbResult - * \brief The result of an awb calculation + * \brief The result of an AWB calculation * * This class holds the result of an auto white balance calculation. */ @@ -57,7 +57,7 @@ namespace ipa { * applied. To keep the actual implementations computationally inexpensive, * the squared colour error shall be returned. * - * If the awb statistics provide multiple zones, the average of the individual + * If the AWB statistics provide multiple zones, the average of the individual * squared errors shall be returned. Averaging/normalizing is necessary so that * the numeric dimensions are the same on all hardware platforms. * @@ -94,7 +94,7 @@ namespace ipa { /** * \fn AwbAlgorithm::calculateAwb - * \brief Calculate awb data from the given statistics + * \brief Calculate AWB data from the given statistics * \param[in] stats The statistics to use for the calculation * \param[in] lux The lux value of the scene * @@ -102,7 +102,7 @@ namespace ipa { * lux value of 0 means it is unknown or invalid and the algorithm shall ignore * it. * - * \return The awb result + * \return The AWB result */ /** @@ -178,14 +178,14 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData, if (controls::AwbModeNameValueMap.find(modeName) == controls::AwbModeNameValueMap.end()) { LOG(Awb, Warning) - << "Skipping unknown awb mode '" + << "Skipping unknown AWB mode '" << modeName << "'"; continue; } if (!modeDict.isDictionary()) { LOG(Awb, Error) - << "Invalid awb mode '" << modeName << "'"; + << "Invalid AWB mode '" << modeName << "'"; return -EINVAL; } @@ -235,7 +235,7 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData, * \class AwbAlgorithm::ModeConfig * \brief Holds the configuration of a single AWB mode * - * Awb modes limit the regulation of the AWB algorithm to a specific range of + * AWB modes limit the regulation of the AWB algorithm to a specific range of * colour temperatures. */ diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp index 49448976ed26..06ffd45618d8 100644 --- a/src/ipa/libipa/awb_grey.cpp +++ b/src/ipa/libipa/awb_grey.cpp @@ -57,7 +57,7 @@ int AwbGrey::init(const YamlObject &tuningData) } /** - * \brief Calculate awb data from the given statistics + * \brief Calculate AWB data from the given statistics * \param[in] stats The statistics to use for the calculation * \param[in] lux The lux value of the scene * @@ -68,7 +68,7 @@ int AwbGrey::init(const YamlObject &tuningData) * * The \a lux parameter is not used in this algorithm. * - * \return The awb result + * \return The AWB result */ AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] int lux) {