From patchwork Thu Feb 13 08:58:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 22778 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 96880BD7D8 for ; Thu, 13 Feb 2025 08:58:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 70F4B68634; Thu, 13 Feb 2025 09:58:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="mNEYbXxr"; dkim-atps=neutral Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5344D61862 for ; Thu, 13 Feb 2025 09:58:31 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43945a9085dso190665e9.1 for ; Thu, 13 Feb 2025 00:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1739437110; x=1740041910; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=j0oPc1hdaT3zJlfUjKGSzdzGsFl/iaR2vT3AbwKNM4Y=; b=mNEYbXxr/YUOeZQ4Qwo0JR/DN+YwrDHjDSBb0XFi8W9z/LNLfrQVHLhmDEYYI68rfp 0WNYRB8k3/Jq/Avq+4eov7me0qmOvIFke0Q7YEMT3WnbIIp2oCcgXyIrr3uy6yYFb4lW mD97EXLxsMCj1/QPJjaCmEkDlC0+81BwSXlI+/kPi1KMf5RjFQ6kPURwjqyBXekJfYqw beqhcl79ed5mCbgc82ty7XgODW0ev1bu1+1UWOOeqUMp4Rv+aKuCnH6kSjapuPusJKLW ndo8ann+EZO547uDlecWtiTcGj8e9kKY/lML7kmKuEf/iuOud3yLMnBLZ2HQNwaQ8lQ6 za3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739437110; x=1740041910; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j0oPc1hdaT3zJlfUjKGSzdzGsFl/iaR2vT3AbwKNM4Y=; b=q1oSvw8d8ybnAHcpk8PBS7hTgLTSjX/8C1kIL12ILBwMa4Ffdbo6jax+n3ACH5oNL/ iTqa21MwatNHqTxKmdqzfyj7bqvHUUTfNUZuyJQa+G5GZgPOqaXAbrFthoA/dVd2iTOl 4LnArfEzsnsW146RwWeHqvp2uAYYwdNha7jtmxSm5jo0LUjFX/MIezmSruYXeZiY5PJS FW29EE60blgXOK9rYomIiH+J4gyYKBiTx0LxJySV6y2uRWKYytpee92Yu/Sax41+gDzY 265e+xi5zCxLtKatFLLCm2zRqqb9cWSvxYm42LjszGytEeiOjJVzCjndNj+4E97eo/vD 4eFQ== X-Gm-Message-State: AOJu0Yz5VugpJvdENHkdMGI4wa/2vhYehIdWW5/RBj6yG70PICTJLl4j ShVThXi4EJKsY+F9Ts3tMf1ku5gZt7jVLIRmSg2Dy6IKxb6zKtu6czVlhoqfomY9DVCcIOxIKB+ 3J9U= X-Gm-Gg: ASbGncs5MiSmcsPgBWOahphM5AGf5ukBQJx8fBFp3o4yVi6mcQN4GTwmZypsagNXDYZ yev52GH6q7kcISuNMXb0WHfUuhPTattdwhr+YaY0OK87QQ0jsdp7r+3ewHqZ3bGdAu7pX4hGCP5 8Si/zsTGxdouDUrkXZtbZ4aJ42xqLm30Yplnws3nYxJR9zSU9OJrc+VLSom/KNGqVcNbsLTIG9B g8fHcLLJj4LbW6/PjaVu4oUvDy1vv8uoawZ+AliMjb8Qwvavp4tacpLjoZTvpW/XMt0lEDN10+a F03i+k/IZF9F43cAraIf/HfImzod9jKVnfc= X-Google-Smtp-Source: AGHT+IEMHNbOgeM+dV+NCd6tNqC/mSIZANmv02VrNxLCCGRBLMkjAO3jcBLknzKQttAgfA0rvvdqEQ== X-Received: by 2002:a05:600c:6a04:b0:439:5b36:7082 with SMTP id 5b1f17b1804b1-4395b367331mr21489975e9.2.1739437110286; Thu, 13 Feb 2025 00:58:30 -0800 (PST) Received: from NAUSH-P-DELL.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439617fdad3sm11185885e9.10.2025.02.13.00.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 00:58:29 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime ControlInfo Date: Thu, 13 Feb 2025 08:58:21 +0000 Message-ID: <20250213085825.228191-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" controls::ExposureTime is of type ControlTypeInteger32, but the default ControlInfoMap casts a value to int64_t causing incorrect initialisation of the associated ControlInfo. Fix this by casting correctly to int32_t. Fixes: bea2db5e ("ipa: rpi: Apply default ControlInfo values for sensor controls") Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Kieran Bingham --- src/ipa/rpi/common/ipa_base.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index d5948c4a1ef4..6734c32ed1b1 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -62,7 +62,7 @@ const ControlInfoMap::Map ipaControls{ static_cast(controls::ExposureTimeModeManual), static_cast(controls::ExposureTimeModeAuto)) }, { &controls::ExposureTime, - ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) }, + ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) }, { &controls::AnalogueGainMode, ControlInfo(static_cast(controls::AnalogueGainModeAuto), static_cast(controls::AnalogueGainModeManual),