From patchwork Mon Feb 3 10:43:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22725 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 56BDEC3260 for ; Mon, 3 Feb 2025 10:43:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0B5326858E; Mon, 3 Feb 2025 11:43:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="Xj7Duvp8"; dkim-atps=neutral Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EE75768585 for ; Mon, 3 Feb 2025 11:43:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1738579417; x=1738838617; bh=5ejtu9YPowddirCWzAzbUxwojEFr/JrgsPcW4/tgres=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=Xj7Duvp8POA21R/RtI2AdCF7CzgnthfF/Y9ZY9uSgJzthcd7tezNH0pNrnyySaY5u bOp5F2HYYPGU5ET0NlN17jV7RbLAHL7f6y5oCQ3rsOvUuicVMdXnvYPQSdJO/thOVE WOvr0JSyB4PF/Yuy64EfVPUnjlWkERszqmDiVEWnF21rJ9kBewjUJnFp+LGTUYoWNS 4WE34Q2v8Hx7GgDPLQg1KXqsvYNiQ7ltorlKTU0/j9fFDRBzJTrz3sWlvqxmTS9Dg7 k7BRh3uQ5PA8raJLR6c0Qn3iS6ZFgTAbDA/bl7CCxulV26NqV8ZsdrU6PsVyGwDIkL MKO5EkR6wq3PA== Date: Mon, 03 Feb 2025 10:43:34 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v1 3/3] libcamera: pipeline: virtual: Set `FrameError` on error Message-ID: <20250203104318.135628-4-pobrn@protonmail.com> In-Reply-To: <20250203104318.135628-1-pobrn@protonmail.com> References: <20250203104318.135628-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton X-Pm-Message-ID: 85e122d89b17603ddd8333d6914737fffd49adb4 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Do not cancel, simply set the buffer's status to `FrameError` to notify the user about the error condition. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/virtual/virtual.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index 1a75f35aa..cbba08c82 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -322,7 +322,7 @@ int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera, if (streamConfig.frameGenerator->generateFrame( stream->configuration().size, buffer)) - buffer->_d()->cancel(); + fmd.status = FrameMetadata::Status::FrameError; completeBuffer(request, buffer); break;