From patchwork Thu Jan 30 11:50:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22676 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 99FF6BDB1C for ; Thu, 30 Jan 2025 11:51:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2B93468580; Thu, 30 Jan 2025 12:51:44 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="mRcu+YI3"; dkim-atps=neutral Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FE366856A for ; Thu, 30 Jan 2025 12:51:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1738237901; x=1738497101; bh=6LZdqGHRubU4bkTEAjaYF73miEfHhdYWLPMaF/agJSE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=mRcu+YI3XD9eLmJ+qUYGvUObuDJ7AYThWK4AGH8r5WumCNjSUXHqnZG3Zgn4fZd2D kPvCCkqI76x3AA/d+n7d3GRcThjCM5t88uMx1JVNXGHOJffFyZMYr7WuCFRXu+O5wZ 3Xdz7zV9SmJ5A10e/lhbSSYUuDkZSnWniLyDQj2PfCOfC6XX+h8XMoubgDT9uDJ393 uVqAlnn5JnL2+5guuaZrkdw9Y/5TKFZTs9Z4I0n39y+L1dBpC/WYj/thZABnNzc6zt 97X/yDXCqp8y02+KORsupDnUtvj6vxpzsTiXiulvBoaju0bgMnkR26xDv36ESLhmET gnD+yPZfid75Q== Date: Thu, 30 Jan 2025 11:50:55 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jacopo Mondi , Paul Elder Subject: [RFC PATCH v3 11/21] apps: lc-compliance: Remove redundant getter call Message-ID: <20250130115001.1129305-12-pobrn@protonmail.com> In-Reply-To: <20250130115001.1129305-1-pobrn@protonmail.com> References: <20250130115001.1129305-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton X-Pm-Message-ID: ce11d9b09d9fa4ef351a0ed915bcc1cda73b571d MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Smart pointers overload `operator->()`, no reason to use `get()`. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/apps/lc-compliance/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp index 98f2573d0..cdd0bd515 100644 --- a/src/apps/lc-compliance/main.cpp +++ b/src/apps/lc-compliance/main.cpp @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener static void listCameras(CameraManager *cm) { for (const std::shared_ptr &cam : cm->cameras()) - std::cout << "- " << cam.get()->id() << std::endl; + std::cout << "- " << cam->id() << std::endl; } static int initCamera(CameraManager *cm, OptionsParser::Options options)