From patchwork Thu Jan 23 14:07:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scally X-Patchwork-Id: 22635 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 59164BDE6B for ; Thu, 23 Jan 2025 14:07:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 799C468564; Thu, 23 Jan 2025 15:07:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pwV60fLh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E047A61879 for ; Thu, 23 Jan 2025 15:07:45 +0100 (CET) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 11B15D1F; Thu, 23 Jan 2025 15:06:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737641202; bh=+1sktMH3NyNzi9oYk3qIY3hescA5XHgRgeofWToMEyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pwV60fLh/toelyfFEB271B4UuvB4WRRqXEE3w10tghVuevxtFpxYnZbIRQA2J4FdU tgwJQeVVMssMgL9Nt/7DuhWvTy/enk4HqA1eMpLOFkU5e4H8YO6U0UYSceQ/r41diM fzMMLQeU406BrO51HOmsnctNWb8Ed4EPoDjctwpw= From: Daniel Scally To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , Laurent Pinchart , Paul Elder Subject: [PATCH v2 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function Date: Thu, 23 Jan 2025 14:07:25 +0000 Message-Id: <20250123140727.458567-2-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250123140727.458567-1-dan.scally@ideasonboard.com> References: <20250123140727.458567-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3 IPA's AGC algorithm currently does not implement a queueRequest() function. We will shortly need to use it, but to avoid lots of noise in the future commit that adds a function call in to that function add it as a skeleton here. Signed-off-by: Daniel Scally Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- Changes in v2: - None src/ipa/ipu3/algorithms/agc.cpp | 10 ++++++++++ src/ipa/ipu3/algorithms/agc.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp index 39d0aebb..383b046c 100644 --- a/src/ipa/ipu3/algorithms/agc.cpp +++ b/src/ipa/ipu3/algorithms/agc.cpp @@ -123,6 +123,16 @@ int Agc::configure(IPAContext &context, return 0; } +/** + * \copydoc libcamera::ipa::Algorithm::queueRequest + */ +void Agc::queueRequest([[maybe_unused]] typename Module::Context &context, + [[maybe_unused]] const uint32_t frame, + [[maybe_unused]] typename Module::FrameContext &frameContext, + [[maybe_unused]] const ControlList &controls) +{ +} + Histogram Agc::parseStatistics(const ipu3_uapi_stats_3a *stats, const ipu3_uapi_grid_config &grid) { diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h index 890c271b..c82b7acb 100644 --- a/src/ipa/ipu3/algorithms/agc.h +++ b/src/ipa/ipu3/algorithms/agc.h @@ -32,6 +32,9 @@ public: int init(IPAContext &context, const YamlObject &tuningData) override; int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; + void queueRequest(IPAContext &context, const uint32_t frame, + IPAFrameContext &frameContext, + const ControlList &controls) override; void process(IPAContext &context, const uint32_t frame, IPAFrameContext &frameContext, const ipu3_uapi_stats_3a *stats,