From patchwork Thu Jan 23 11:41:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22631 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 26335BDE6B for ; Thu, 23 Jan 2025 11:43:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C71026857D; Thu, 23 Jan 2025 12:43:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="p7MAE279"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D954168571 for ; Thu, 23 Jan 2025 12:42:58 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:c0a:33cd:b453:5d3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A8AB1189; Thu, 23 Jan 2025 12:41:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737632515; bh=E3KIgkFPJeb67Axw3W6YCY98X3du1OG/vzDBhEKPFkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p7MAE279BNRf0xyVgwlAJ3zd7WKuX7x4XDb6XYfbvR7m6RZKQ7WgADggHLJ19nODF yBBOTiwiUOqcNHXcg5V8wBKRckEewxCWYMQm2PsycgwJlq3nORXC/URqkMxLHCc3bJ NQT5QXaNAJn1XCzVp1J3s7KI42JfdXdbe4CiXKTY= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v2 16/17] libipa: awb_bayes: Remove overly verbose log messages Date: Thu, 23 Jan 2025 12:41:06 +0100 Message-ID: <20250123114204.79321-17-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250123114204.79321-1-stefan.klug@ideasonboard.com> References: <20250123114204.79321-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Logging every search step is too verbose even with debug messages enabled and it hides the more important messages (min max values of errors and likelihoods). Remove the debug messages in a separate commit, so that it can easily be reverted if needed. Signed-off-by: Stefan Klug Reviewed-by: Paul Elder Reviewed-by: Daniel Scally --- Changes in v2: - Added this commit --- src/ipa/libipa/awb_bayes.cpp | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp index aaa8c7a663ad..6b88aebeffb5 100644 --- a/src/ipa/libipa/awb_bayes.cpp +++ b/src/ipa/libipa/awb_bayes.cpp @@ -330,12 +330,6 @@ double AwbBayes::coarseSearch(const ipa::Pwl &prior, const AwbStats &stats) cons errorLimits.record(delta2Sum); priorLogLikelihoodLimits.record(priorLogLikelihood); - LOG(Awb, Debug) << "Coarse search t: " << t - << " gains: " << gains - << " error: " << delta2Sum - << " prior: " << priorLogLikelihood - << " likelihood: " << finalLogLikelihood; - points.push_back({ { t, finalLogLikelihood } }); if (points.back().y() < points[bestPoint].y()) bestPoint = points.size() - 1; @@ -453,13 +447,6 @@ void AwbBayes::fineSearch(double &t, double &r, double &b, ipa::Pwl const &prior double delta2Sum = stats.computeColourError(gains); errorLimits.record(delta2Sum); double finalLogLikelihood = delta2Sum - priorLogLikelihood; - LOG(Awb, Debug) - << "Fine search t: " << tTest - << " r: " << rbTest[0] - << " b: " << rbTest[1] - << " offset: " << bestOffset - << " likelihood: " << finalLogLikelihood - << (finalLogLikelihood < bestLogLikelihood ? " NEW BEST" : ""); if (bestT == 0 || finalLogLikelihood < bestLogLikelihood) { bestLogLikelihood = finalLogLikelihood;