From patchwork Mon Jan 20 20:45:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22599 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 71797C3316 for ; Mon, 20 Jan 2025 20:45:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C6F4D6855E; Mon, 20 Jan 2025 21:45:50 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Vtginwzf"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 179546855E for ; Mon, 20 Jan 2025 21:45:39 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5694322A; Mon, 20 Jan 2025 21:44:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737405877; bh=V2AwM77ZACctVud/nFgqq9P/EKmhF5hJ/kf+VZjFq1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VtginwzfeWz/H2l667N9bDp2YdyoTwYpRpY0C2fqRSPO2InS7Hy4JDKNw6HxU9t8z Dw/0l2poxsFcNgJEuhry3Lel//ohOywzV3eGfWO0KKYQcrH3bLX5f4nDJNquYhdf5L CmiAhsDALfi4qLfvl5VbIrLXrrvZOxHaA5S6RBXs= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Paul Elder Subject: [PATCH v9 12/12] ipa: raspberry: Report new AeEnable control as available Date: Mon, 20 Jan 2025 22:45:03 +0200 Message-ID: <20250120204515.24096-13-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250120204515.24096-1-laurent.pinchart@ideasonboard.com> References: <20250120204515.24096-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Paul Elder Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rpi IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Stefan Klug Reviewed-by: Naushir Patuck Signed-off-by: Laurent Pinchart --- src/ipa/rpi/common/ipa_base.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 5210a1f38efb..bd3c22000df5 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0; /* List of controls handled by the Raspberry Pi IPA */ const ControlInfoMap::Map ipaControls{ + /* \todo Move this to the Camera class */ + { &controls::AeEnable, ControlInfo(false, true, true) }, { &controls::ExposureTimeMode, ControlInfo(static_cast(controls::ExposureTimeModeAuto), static_cast(controls::ExposureTimeModeManual),