From patchwork Mon Jan 20 20:45:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 22598 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 01CABC3315 for ; Mon, 20 Jan 2025 20:45:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 622CB68564; Mon, 20 Jan 2025 21:45:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ag8YCE/l"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B2221684E7 for ; Mon, 20 Jan 2025 21:45:37 +0100 (CET) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 08D8F22A; Mon, 20 Jan 2025 21:44:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737405876; bh=sYhT81i81W1qTVAQTvCU5bVXYNAIta96R39H/NyVcK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ag8YCE/laa73dis7P3l2V1e/22ZUxuutaZ5LNxR6IpCa9WO+Jcy01yhYtDUn0lEHJ Z/B6KttykjUPDivXNbqC6FJsQtcW7MEyIK4S1U6fD2qD/jHCv9HK/fgYzM/bXFobVZ Hkq5nSsQ4Mm1z8MGMQx+M/NVKIbuIDKSMjXwWSXg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Paul Elder Subject: [PATCH v9 11/12] ipa: rkisp1: agc: Report new AeEnable control as available Date: Mon, 20 Jan 2025 22:45:02 +0200 Message-ID: <20250120204515.24096-12-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250120204515.24096-1-laurent.pinchart@ideasonboard.com> References: <20250120204515.24096-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Paul Elder Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rkisp1 IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Stefan Klug Signed-off-by: Laurent Pinchart --- src/ipa/rkisp1/algorithms/agc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 78122a1f05f8..1680669c6875 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData) ControlInfo(static_cast(controls::AnalogueGainModeAuto), static_cast(controls::AnalogueGainModeManual), static_cast(controls::AnalogueGainModeAuto)); + /* \todo Move this to the Camera class */ + context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true); context.ctrlMap.merge(controls()); return 0;