From patchwork Fri Jan 17 14:34:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 22581 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2703DBD7D8 for ; Fri, 17 Jan 2025 14:34:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D224C6854A; Fri, 17 Jan 2025 15:34:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MBO5TDl6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F1EF6851B for ; Fri, 17 Jan 2025 15:34:21 +0100 (CET) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 08969874; Fri, 17 Jan 2025 15:33:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1737124402; bh=c98Vnrgel42oLF875b2YKlI3NVdnbzSpmKC0kcTjipc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MBO5TDl6/+aLZsgKs5v0/q12QxpCwN5CctiC4+iXnwcp8j0r2sDm/bO8pPEJe0yqI m7RGlpurL7hZLRp8YA5Q2ErJ9Ns+4K2LJzU6k+9nZfVBZcUWvSTa6lcAnaCaLC5vDa /CZUhdvWUhys/rUep3z6aaFgDIfafUTJwlJwdhMc= From: Daniel Scally To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally Subject: [PATCH 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function Date: Fri, 17 Jan 2025 14:34:08 +0000 Message-Id: <20250117143410.20363-2-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250117143410.20363-1-dan.scally@ideasonboard.com> References: <20250117143410.20363-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3 IPA's AGC algorithm currently does not implement a queueRequest() function. We will shortly need to use it, but to avoid lots of noise in the future commit that adds a function call in to that function add it as a skeleton here. Signed-off-by: Daniel Scally Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- src/ipa/ipu3/algorithms/agc.cpp | 10 ++++++++++ src/ipa/ipu3/algorithms/agc.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp index 39d0aebb..383b046c 100644 --- a/src/ipa/ipu3/algorithms/agc.cpp +++ b/src/ipa/ipu3/algorithms/agc.cpp @@ -123,6 +123,16 @@ int Agc::configure(IPAContext &context, return 0; } +/** + * \copydoc libcamera::ipa::Algorithm::queueRequest + */ +void Agc::queueRequest([[maybe_unused]] typename Module::Context &context, + [[maybe_unused]] const uint32_t frame, + [[maybe_unused]] typename Module::FrameContext &frameContext, + [[maybe_unused]] const ControlList &controls) +{ +} + Histogram Agc::parseStatistics(const ipu3_uapi_stats_3a *stats, const ipu3_uapi_grid_config &grid) { diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h index 890c271b..c82b7acb 100644 --- a/src/ipa/ipu3/algorithms/agc.h +++ b/src/ipa/ipu3/algorithms/agc.h @@ -32,6 +32,9 @@ public: int init(IPAContext &context, const YamlObject &tuningData) override; int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; + void queueRequest(IPAContext &context, const uint32_t frame, + IPAFrameContext &frameContext, + const ControlList &controls) override; void process(IPAContext &context, const uint32_t frame, IPAFrameContext &frameContext, const ipu3_uapi_stats_3a *stats,