From patchwork Tue Jan 14 18:22:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22569 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 097B1C3301 for ; Tue, 14 Jan 2025 18:22:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AF4BB6854C; Tue, 14 Jan 2025 19:22:32 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="o7J4qkTh"; dkim-atps=neutral Received: from mail-10629.protonmail.ch (mail-10629.protonmail.ch [79.135.106.29]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B36D5684E4 for ; Tue, 14 Jan 2025 19:22:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1736878951; x=1737138151; bh=wkrIB4YgmYKmQEgNV1q7PTX5QcDbokZN9TquUHAcD+I=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=o7J4qkThVbmGwAdTOExh27PS+mUmb7qrQM7xP99ncN5UHSZCufW8/wrWhT6iEkiD5 AP2w526Xc2YLBt6VsAY7NzEdw063HPzxUupi9PaDq/0qOMMuRfcyjdsPO+XALyONgx 17QaNkQFN2JUCS3umEjulkoVMHDF3+AUs6G4/bFyzwO19eMt/kNQMpEIB+jL2LE9gU pP/0u2upZeVdO9FGwGFdIO4D165RvpsHeK0UoHvgo4xIR+6FSFT9m4LsoOiJXVFIzH tmKxQLTRqwy8zcsySOpSX+HpKCNb7bURrVB2vvlUDfAh2ZaUoMHD/8HfyykUCzNZ87 xGHeKiy+NeuRQ== Date: Tue, 14 Jan 2025 18:22:28 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jacopo Mondi , Paul Elder Subject: [RFC PATCH v2 08/16] apps: lc-compliance: Remove redundant getter call Message-ID: <20250114182143.1773762-9-pobrn@protonmail.com> In-Reply-To: <20250114182143.1773762-1-pobrn@protonmail.com> References: <20250114182143.1773762-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton X-Pm-Message-ID: 6e36770f0607cdcefc1c740cdd70c334b17daec6 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Smart pointers overload `operator->()`, no reason to use `get()`. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/apps/lc-compliance/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp index 98f2573d0..cdd0bd515 100644 --- a/src/apps/lc-compliance/main.cpp +++ b/src/apps/lc-compliance/main.cpp @@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener static void listCameras(CameraManager *cm) { for (const std::shared_ptr &cam : cm->cameras()) - std::cout << "- " << cam.get()->id() << std::endl; + std::cout << "- " << cam->id() << std::endl; } static int initCamera(CameraManager *cm, OptionsParser::Options options)