From patchwork Mon Jan 13 21:59:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22559 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 23B38BD1F1 for ; Mon, 13 Jan 2025 22:02:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 90ED768555; Mon, 13 Jan 2025 23:02:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="T8wgs2U6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45C0768557 for ; Mon, 13 Jan 2025 23:02:25 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (unknown [173.16.167.215]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FC684388; Mon, 13 Jan 2025 23:01:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736805688; bh=51hnUcpAKWE15oX752PYg+bqUwWeVn4sj40cgvK8qpk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T8wgs2U6Jbmg9nktB2R1E5j5uw69GvGIhHMdMR6Kpi59LNms3b53QYwteqhaglxIo bpbq1LWiLljFQ2UJriWb00oCryd7WxlEXzh4DrZE0IFprv+b8R7J+a7yMEopzBgZKT J86xTLEHHbOsXfkB4ca8eEXauCLae0EF23llTBSk= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , laurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com, david.plowman@raspberrypi.com, naush@raspberrypi.com Subject: [PATCH v8 12/12] ipa: raspberry: Report new AeEnable control as available Date: Mon, 13 Jan 2025 15:59:46 -0600 Message-Id: <20250113215946.1033762-13-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250113215946.1033762-1-paul.elder@ideasonboard.com> References: <20250113215946.1033762-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rpi IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Stefan Klug Reviewed-by: Naushir Patuck --- Changes in v8: - add "true" as default value No change in v7 New in v6 --- src/ipa/rpi/common/ipa_base.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 0fb58c1d0..a5c46e6ec 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0; /* List of controls handled by the Raspberry Pi IPA */ const ControlInfoMap::Map ipaControls{ + /* \todo Move this to the Camera class */ + { &controls::AeEnable, ControlInfo(false, true, true) }, { &controls::ExposureTimeMode, ControlInfo(static_cast(controls::ExposureTimeModeAuto), static_cast(controls::ExposureTimeModeManual),