From patchwork Mon Jan 13 21:59:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22558 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A60E1C3311 for ; Mon, 13 Jan 2025 22:02:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 533C468536; Mon, 13 Jan 2025 23:02:26 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZOE3N5tV"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C16AF68553 for ; Mon, 13 Jan 2025 23:02:23 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (unknown [173.16.167.215]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 64C5C4387; Mon, 13 Jan 2025 23:01:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736805687; bh=lq5kGCuheQrIqlLwkxwlJEe8cWaKetEBCAtalPkG5GQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZOE3N5tVKpQO5uXRJF5LG6crxr+xWQ0L6Q/c/rWChqxqerJfWerXnLiWr/cpwOd5n xk9FPR+4lYSpg41pNMDbvWzIStcNI+gtYVWfiw05c2UnlQjXirPDL2G1NLN5dW7l4y Ho+G5cojutrmoqWl+VpaTh9YWLv304eX4L0DI/eE= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , laurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com Subject: [PATCH v8 11/12] ipa: rkisp1: agc: Report new AeEnable control as available Date: Mon, 13 Jan 2025 15:59:45 -0600 Message-Id: <20250113215946.1033762-12-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250113215946.1033762-1-paul.elder@ideasonboard.com> References: <20250113215946.1033762-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rkisp1 IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Stefan Klug --- Changes in v8: - add "true" as default value No change in v7 New in v6 --- src/ipa/rkisp1/algorithms/agc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 78122a1f0..1680669c6 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData) ControlInfo(static_cast(controls::AnalogueGainModeAuto), static_cast(controls::AnalogueGainModeManual), static_cast(controls::AnalogueGainModeAuto)); + /* \todo Move this to the Camera class */ + context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true); context.ctrlMap.merge(controls()); return 0;