From patchwork Fri Jan 10 23:57:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22521 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 94447C32FB for ; Fri, 10 Jan 2025 23:58:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 040DE68549; Sat, 11 Jan 2025 00:58:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VX21MBkC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50C8B6854D for ; Sat, 11 Jan 2025 00:58:14 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (unknown [IPv6:2604:2d80:9e93:ad00:3d82:7e4f:ab9b:8a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E0D7E19E7; Sat, 11 Jan 2025 00:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736553439; bh=nx3OgWv78aOHGMHtaV/v/IcF9RfnJdqZL49n4rBjEOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VX21MBkCK6Rb/2w239/JifkJcjlpx967friwTrI2VQuPSbtNBiMKQrNn23b4yQvMA eaqo9F/K6RxenEC6dIjo3Dxbd3IE7e+iNfZYyv3PXw9ECa/1F2/NBURPHs1k3vo7tx pCbN/k+zQoqB0QI5tW8/MaND2B4qXMPiIHBKPjus= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , laurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com Subject: [PATCH v7 12/12] ipa: raspberry: Report new AeEnable control as available Date: Fri, 10 Jan 2025 17:57:37 -0600 Message-Id: <20250110235737.1524733-13-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250110235737.1524733-1-paul.elder@ideasonboard.com> References: <20250110235737.1524733-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rpi IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart Reviewed-by: Stefan Klug --- No change in v7 New in v6 --- src/ipa/rpi/common/ipa_base.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index d6721c49c..95aa460ab 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0; /* List of controls handled by the Raspberry Pi IPA */ const ControlInfoMap::Map ipaControls{ + /* \todo Move this to the Camera class */ + { &controls::AeEnable, ControlInfo(false, true) }, { &controls::ExposureTimeMode, ControlInfo(static_cast(controls::ExposureTimeModeAuto), static_cast(controls::ExposureTimeModeManual)) },