From patchwork Thu Jan 9 00:09:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22485 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 30D43C3319 for ; Thu, 9 Jan 2025 00:10:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 746706854F; Thu, 9 Jan 2025 01:10:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Ve12ljxS"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B395C68500 for ; Thu, 9 Jan 2025 01:10:12 +0100 (CET) Received: from pyrite.hamster-moth.ts.net (unknown [IPv6:2604:2d80:9e93:ad00:3d82:7e4f:ab9b:8a]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A0AC11F1; Thu, 9 Jan 2025 01:09:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736381359; bh=QfykDUOINS/cQGLJPiSZ7a9QcoQb3YgBabHxTfBk0xo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ve12ljxSUwGlk6kKCiSQTuLT8EgQVKGUcTuM9PGCtFhqGeL1qMaT0l57hwT4yS+wB i/zMjWDuQMJVJA54ockJb1q0bVoUGcljZEn7ouB39J8OOf+/UEeMaBtgFzi/+pLuDE AZVR9v7IPJcfsLiPGgc+5MOZDkLFNo62BXZqhozo= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , laurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com Subject: [PATCH v6 12/12] ipa: raspberry: Report new AeEnable control as available Date: Wed, 8 Jan 2025 18:09:42 -0600 Message-Id: <20250109000942.1616565-13-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250109000942.1616565-1-paul.elder@ideasonboard.com> References: <20250109000942.1616565-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Even though the new AeEnable control internally switches on and off the sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to be declared as available. Report this control as available in the rpi IPA. Support for the control does not need to be added as it is handled by the Camera class. It does not need to be handled in metadata either as the new version of AeEnable is not returned in metadata. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart --- New in v6 --- src/ipa/rpi/common/ipa_base.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 4334d22e1..44ce38caa 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0; /* List of controls handled by the Raspberry Pi IPA */ const ControlInfoMap::Map ipaControls{ + /* \todo Move this to the Camera class */ + { &controls::AeEnable, ControlInfo(false, true) }, { &controls::ExposureTimeMode, ControlInfo(static_cast(controls::ExposureTimeModeAuto), static_cast(controls::ExposureTimeModeManual)) },