From patchwork Wed Jan 8 11:09:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 22470 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 85BAABD80A for ; Wed, 8 Jan 2025 11:10:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6F00568516; Wed, 8 Jan 2025 12:10:41 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="SJ4kK9k1"; dkim-atps=neutral Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 85D01684E2 for ; Wed, 8 Jan 2025 12:10:37 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4361e82e3c3so25989175e9.0 for ; Wed, 08 Jan 2025 03:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1736334637; x=1736939437; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=; b=SJ4kK9k1R2xp0iAoTzSFQvWvtBSbDHrAfVbQmk8ukYxOGrl22wihYdK2NEA0/SaLU3 UO5DoCJEQUUny+oaxzfhd5IpyCEpsao1cXNZ4TJRF6iaIl/UaduJ3cWU2efxl+Qp/dFK WSuP4PtHu7X2hf1b6+8Yp43k/Nqo6tjQyfsUTAaYcrl/61gqoornGjCgh7u3VRCmMjqs IvDRdTZP57IkoVnjeo7o6I88izJkCbMqLfarin5bc7yTXVLLWE/wo1AMyX7pKFQwrRvy LhvjgHpFMadTusZbzzaFYVj3810hLhwpMwLymQFLw67z8Ub3rGy5ltG5kBxfP+rTb0XU fwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736334637; x=1736939437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=; b=Hsue7vD4cB0+I3eQZjSEuSCopbYMsS8/4ZDuibCMhvw/5yfiVdBy4CYim7eUjGGOKx Pt0HlYhijWHWbdP2I2di4s3fS5ioNL0hyWi8vNNnHmjSNqxHZTGHEGXex9x56jxYS7GT 3WuXVI3VGYZK5bt+a/7BIF56gGjgKVuqf7JHlT/0ltfMIJLI36bHAvE5LKK0TzlCG0yB xPO7NxWbTNyqFI0iZ3f2rusjhmOwffb5MSA5JYsNIrH92YC+k1DkAPatxh4rVGUMrqsH yADKCTjlLAid4bowONlWQmaeHYBXViIuhj2YswJ5lETQGzwuEPmfglzXuzH9IHN3RQmK /0Mg== X-Gm-Message-State: AOJu0Yw/MtqMEKUbrwE6G0rxR633cibvEwYFLP8MiLrtPWo/3bA2VSTF 17GE9077y4NbJd0m/gsUTaLVAWQD0oY/4flIE8S+iFjTPj+aUZTxjntusG8jVbX3NbqJNRHKjGZ kEhg= X-Gm-Gg: ASbGncu0oBD7jUuQYFScGnJDQ7U4xNvXmvv70HYatpV5dO3K5226YFlby6aAPbmnXBO cMXUPm4oAvjZhqOt/Yja81PKFNDLGZmW/ehLSgY6H8xz4GOGHYLp9Ik3xfbK/J2O80yvxNuGUXj wciqcBycaRs2FmRDi6K2h+sNrvB9co432BtwyRL4y8lxvZOtT23huStJm5xfnNQlG+GaxISSYVV THp3Lyndlsduhg4wusd+MeafVbanlxL8Z83XSxQxAJNQEvEaLcmUk7rlQSZ/SxA3SalEdnH2B1D X-Google-Smtp-Source: AGHT+IEZ8EGlXCHz8Njxi2CDY/KVHhEmhtBs4zXZ8LCn5ZJ1uspM+SwZdj6VFKoNRBwZn461PWHYEQ== X-Received: by 2002:a05:600c:3ca0:b0:436:17f4:9b3b with SMTP id 5b1f17b1804b1-436e270729bmr7513835e9.6.1736334636745; Wed, 08 Jan 2025 03:10:36 -0800 (PST) Received: from NAUSH-P-DELL.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2ddefcbsm17141325e9.22.2025.01.08.03.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 03:10:36 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart Subject: [PATCH v3 3/4] ipa: rpi: Add a HW property to determine if the data buffer is strided Date: Wed, 8 Jan 2025 11:09:35 +0000 Message-ID: <20250108111030.3257931-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250108111030.3257931-1-naush@raspberrypi.com> References: <20250108111030.3257931-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This property (dataBufferStrided) indicates if the CSI-2 hardware writes to the embedded/metadata buffer directly, or if it treats the buffer like an image buffer and strides the metadata lines. Unicam writes this buffer strided, while the PiSP Frontend writes to it directly. This information will be relevant to data parsers in the helpers where the data is structured in lines. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/rpi/controller/controller.cpp | 2 ++ src/ipa/rpi/controller/controller.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp index e0131018e7b2..651fff632400 100644 --- a/src/ipa/rpi/controller/controller.cpp +++ b/src/ipa/rpi/controller/controller.cpp @@ -39,6 +39,7 @@ static const std::map HardwareConfigMap .pipelineWidth = 13, .statsInline = false, .minPixelProcessingTime = 0s, + .dataBufferStrided = true, } }, { @@ -71,6 +72,7 @@ static const std::map HardwareConfigMap * frames wider than ~16,000 pixels. */ .minPixelProcessingTime = 1.0us / 380, + .dataBufferStrided = false, } }, }; diff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h index eff520bd61de..fdb46557de9c 100644 --- a/src/ipa/rpi/controller/controller.h +++ b/src/ipa/rpi/controller/controller.h @@ -49,6 +49,7 @@ public: unsigned int pipelineWidth; bool statsInline; libcamera::utils::Duration minPixelProcessingTime; + bool dataBufferStrided; }; Controller();