From patchwork Fri Dec 20 16:26:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 22442 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CD124C327D for ; Fri, 20 Dec 2024 16:27:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7C681684BB; Fri, 20 Dec 2024 17:27:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GQB2V1MQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C96BD684AE for ; Fri, 20 Dec 2024 17:27:32 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:4eeb:7fa7:1fd0:c13d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CF1BC67; Fri, 20 Dec 2024 17:26:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1734712013; bh=3XmdSfN/v8OjC8PlxJ9vF+iIzbnfS+VhnzlsHUyWUA4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQB2V1MQEam5ZHu2RQmsTkA5/za+ZUWs7VSYPLY6CVwLjjPMSg5OfCvT8R74CRabb W3gTH2xr/KsYyYE75Kchmh1Wv+TjWAcRCzogX7pWN51d7vYZwrrimJJtzq16HDlfXG kzEeAy2Rm8oSBSMyTPotfBZ317PlSrQfm28KfQyg= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [RFC PATCH 2/7] libcamera: delayed_controls: Increase log level for dummy pushes Date: Fri, 20 Dec 2024 17:26:48 +0100 Message-ID: <20241220162724.756494-3-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241220162724.756494-1-stefan.klug@ideasonboard.com> References: <20241220162724.756494-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When an automatic no-op is queued a debug message is printed. Change the debug level to warning, because that situation is actually an indication of something going seriously out of sync. Signed-off-by: Stefan Klug --- src/libcamera/delayed_controls.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp index 6c82d5058ae8..2f134cbe7fdd 100644 --- a/src/libcamera/delayed_controls.cpp +++ b/src/libcamera/delayed_controls.cpp @@ -303,7 +303,7 @@ void DelayedControls::applyControls(uint32_t sequence) writeCount_ = sequence + 1; while (writeCount_ > queueCount_) { - LOG(DelayedControls, Debug) + LOG(DelayedControls, Warning) << "Queue is empty, auto queue no-op."; push(queueCount_, {}); }