From patchwork Wed Dec 18 08:34:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 22394 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A0900C3305 for ; Wed, 18 Dec 2024 08:36:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 838A668083; Wed, 18 Dec 2024 09:36:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="OHA82nAd"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D82E68083 for ; Wed, 18 Dec 2024 09:36:19 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-385db79aafbso549517f8f.1 for ; Wed, 18 Dec 2024 00:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1734510978; x=1735115778; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=; b=OHA82nAdfXrytQjZafDmt57XhZEgMq70KPs4pJsv722OxO5Z91xEE4d+BA5yY0DAUj IyAzstd7dYOtogQDLaOf45mC1ao5K/6Qwp4LwhgJaoSFn4WGUbqINIa7EzRsimPYtTLh iSLMfHMPFozsmXqB7A0auLb3GjlSqkjYSifaG7pbB6eyV+mx4HJC6BC8zGancoUvkbbf FkpM7FQm4lJkzYBFW07CzcUMGywMWJdX+FMn4E+7ra+b9Rh8g1N6GFtg2u3sLwdTRtLH 094rbJuOOyir207cJC0SVRRYSaE0fy21foQl+Zrc8OPUQLg0QPtcaGP/wQm3NC09+FYD ul+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734510978; x=1735115778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LMWk2T6O0FX1QjFHGshf9zrKq9ib51COSr3XgGiWJjk=; b=CDlguyUJ1rlopvhX/hbbSccOMPIVaKCxkq9G2FJSAHFjOJY3CKePUXlwZYknDqCp2X qiH3yMA/BlFrGQEEf2B4VQ0rhQ62Ja17oLLr166U/AE6th7VSsiFR59bAqljxafqlFs8 OvPwUeNfEDz+eGpTrT9uf0rOQe+LqJfIRgY94EHcqqkqY/XUyOIEjHX9770XkqmUikWW cGdgCKovhr/F/P8G+uONG7++FrRA08b9F4jhLKMuNyitLaSCBrZnxJq0xwEDeYKq5c7l qEA1/Hi90VJBGAOvlcbsbV5JTuNUxrXANMzpWww1nnQzU7iQTBUq/WVYQLFlHtcwpE8Q 4fjA== X-Gm-Message-State: AOJu0YzIKqvyEvZ26gKqNbIMOseGs9u3gk2MLg5T9WD0MzZUCEEavjCf EDSBs9Kbd31v8uDSwjyxmQsGepoqJ2REJ1jn4GlKBLeeoJb/1TxlDHCdMiOUE51S3ArKhOqKOID y X-Gm-Gg: ASbGncteqHTI8G1T3e8CHljVMjnqkM9UXK6ft+1wNd0Ksm93bXSdhG9Xsmox/pxOTAb JAFpNEqFp9PDYvpRFcEDoJ/gY43teCWxLyjVftFHYg1Kzz9O7OaNeaPZwY1gJ8v02DeBouWJn2W Z4Vfnu3TNBxydHQg6HPScWVIt6dr5EWAHKm53FzrP45mOFjWhnKEdkuMJtSIN+4bdwd+kYklFQ1 c4w/0jSu0MMr2oaGl+yC9ATnzt8fl7SIzJj1qYWtWoDuLUSUEr5HiTKaEJ0XUV9CF50CDbLmVq/ X-Google-Smtp-Source: AGHT+IHPnOq2KonQgYZnb4Z9LbsnRplXfPysJ6Y85Eu8aXQD8gtp0u6s8lYtSXAQThR2mFqqGeGoDA== X-Received: by 2002:a05:6000:18a3:b0:374:ca43:ac00 with SMTP id ffacd0b85a97d-388e4d4b5f3mr599613f8f.4.1734510978372; Wed, 18 Dec 2024 00:36:18 -0800 (PST) Received: from NAUSH-P-DELL.pitowers.org ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c804a2f9sm13585781f8f.77.2024.12.18.00.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 00:36:17 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart Subject: [PATCH v2 3/4] ipa: rpi: Add a HW property to determine if the data buffer is strided Date: Wed, 18 Dec 2024 08:34:20 +0000 Message-ID: <20241218083610.2397879-4-naush@raspberrypi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241218083610.2397879-1-naush@raspberrypi.com> References: <20241218083610.2397879-1-naush@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This property (dataBufferStrided) indicates if the CSI-2 hardware writes to the embedded/metadata buffer directly, or if it treats the buffer like an image buffer and strides the metadata lines. Unicam writes this buffer strided, while the PiSP Frontend writes to it directly. This information will be relevant to data parsers in the helpers where the data is structured in lines. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Reviewed-by: Laurent Pinchart --- src/ipa/rpi/controller/controller.cpp | 2 ++ src/ipa/rpi/controller/controller.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp index e0131018e7b2..651fff632400 100644 --- a/src/ipa/rpi/controller/controller.cpp +++ b/src/ipa/rpi/controller/controller.cpp @@ -39,6 +39,7 @@ static const std::map HardwareConfigMap .pipelineWidth = 13, .statsInline = false, .minPixelProcessingTime = 0s, + .dataBufferStrided = true, } }, { @@ -71,6 +72,7 @@ static const std::map HardwareConfigMap * frames wider than ~16,000 pixels. */ .minPixelProcessingTime = 1.0us / 380, + .dataBufferStrided = false, } }, }; diff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h index eff520bd61de..fdb46557de9c 100644 --- a/src/ipa/rpi/controller/controller.h +++ b/src/ipa/rpi/controller/controller.h @@ -49,6 +49,7 @@ public: unsigned int pipelineWidth; bool statsInline; libcamera::utils::Duration minPixelProcessingTime; + bool dataBufferStrided; }; Controller();