From patchwork Tue Dec 17 14:33:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Celine Laurencin X-Patchwork-Id: 22377 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A3CD9C32F6 for ; Tue, 17 Dec 2024 14:33:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EF7C467FD3; Tue, 17 Dec 2024 15:33:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="EONi1n2b"; dkim-atps=neutral Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20622.outbound.protection.outlook.com [IPv6:2a01:111:f403:2614::622]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FA4767F0D for ; Tue, 17 Dec 2024 15:33:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fpyFVOUOmDnf7Yd+o4LWsmu/mfEBHQWyvuI8BYf4L+U5L06DCpaHHg1W8XkqCXiYiRw8jO6MHaJVXdS7u97JqLwWSbYlh59yYTW/LnW2rVyAvEAUV0eR+ORgynW2NMJJAYUGaX9Jj5GfSDU9DQlEphXxIwH/m1USVDPWOLNmLER34gjOT8oeycstvZ433OkmO8cBKJRE4AtOvG3xnUWQyOP4XIKbDeB9b1qOkXmGDmHL9Rylom4ZUfHmm4rbDIkGb317QlJ/gqp4rstgjLtlyR/crloQppqAJ2aN1tUiv6tRRDAYMHlPDIlOJjxrm1JUC6sliZ/8y4kz5/6pkCIgZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nUPZ3OyggvYYYsqoEfVRiHhoCEWwziYozWYCMvKv0cg=; b=vpaE1Sk5dQxbCAjg+yy39395tLq3XKcUGIZQiod+EY1BQO/DwF4NNv9NY46+v1Z+P/GWGH4pSes6J+MPXICBD552oJwQG1ABESs7kXxcAgeP0pqD2y9ts5CMZrbXjzOb2uGJ5q4E0P/unZJsVd5DLUPULoOjNlo4LqYfo1U8mkQclAaw1pCv/r+KcIbEiOZ9pOHa2YEJ0FfU0U//nx1vsuZ2+dc3dPSMSyEtBPwL97cFSPAs4UZd8Gwxa8jZx795fHLJtUSnS6oo9DsuxWxwY4HTDig0QiKM452RGNzSF1NlovVw16CjuiKeHtWe25vrCGlDdK7IK91Pqqan0XSzNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUPZ3OyggvYYYsqoEfVRiHhoCEWwziYozWYCMvKv0cg=; b=EONi1n2bsvGUTMZlSRP+E+iHvnYKN8mCQUZvdzqWBI0yqcKF0lJys52FoGROnxBStEpFBYgKa25LRCfCJijp5WJZubx6cEW+9AFVlHoxo19WXS4tfv97EjNtI6WPCgyT2T9+Fj8V4BRkiXvLtjlomRSN2V5pFcV0kcOPgMtjvetSec3g3bIv7V/VMoylx8zXJASKX/n4+o+wZlnV3YC/jK+vFYqIkjC/3iQXL0WdBhK/ivW7gHdWRt9ICmOFPApcgYqukox4O4W32gRhIVoUYGxpaAXaLkRv/C6o0nIaK8ECYnvkXPYcQ7D3Rqqt7UpqS5PQf3CEK/C69AyZ26PriA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB9094.eurprd04.prod.outlook.com (2603:10a6:20b:445::22) by AM8PR04MB7730.eurprd04.prod.outlook.com (2603:10a6:20b:242::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.22; Tue, 17 Dec 2024 14:33:43 +0000 Received: from AS8PR04MB9094.eurprd04.prod.outlook.com ([fe80::b9cf:567c:515d:f1de]) by AS8PR04MB9094.eurprd04.prod.outlook.com ([fe80::b9cf:567c:515d:f1de%4]) with mapi id 15.20.8251.015; Tue, 17 Dec 2024 14:33:43 +0000 From: Celine Laurencin To: libcamera-devel@lists.libcamera.org, julien.vuillaumier@nxp.com, celine.laurencin@nxp.com Subject: [PATCH v1] ipa: mojom: Add sensor ID to IPACameraSensorInfo Date: Tue, 17 Dec 2024 15:33:35 +0100 Message-Id: <20241217143335.401235-1-celine.laurencin@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: AS4P195CA0004.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:5e2::19) To AS8PR04MB9094.eurprd04.prod.outlook.com (2603:10a6:20b:445::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9094:EE_|AM8PR04MB7730:EE_ X-MS-Office365-Filtering-Correlation-Id: cc7191da-299b-42e9-1fe0-08dd1ea7ce7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: L3fTkUDuNglY4iZvBAent4sCVlGzkYchODCYIni62MUx6AnbwRpLwxk4haxhk04D+UyKjcLCe3V3JOUO9Rw0nubVig4hiLDaksehw2hpfNDu2VP81ZJTQQJY2yts8Q4XpqKcmrNNPEymUYpB3bTBO09cibo1pTELEHbTNvv6z84e9IFzIh4JGATEZZSh6PyWKV8tpQ882KrsPcpeCrg2UV7sJnBVPtv+Um1AvIcE+gbHe1WSxgylg5ngMQ3HhoiTEtAp91u4NUqtpUbue+e5jD6WWQbZU08i6hjEPl1e1/oujpgLSsCVKh/34KCaRR6ZamASIp6k/Kw+EWkDvzofzSw0rupBOkLQO1CAiAds6ErXZqzQXE/Ivu7IzDehwuySs9AHbdNmaWz6Ii6PeXz9JHEUBbAUEi7wIYUcp2A7jZpAXP3vmMPskF6Bv/EYSn+NolP33avMHw8v7CJywen6YTZldhPjZgGeL4ADvhNles+RgThgOIWl2vXCoqkVXXxGbVmTLVw6WaXd8gV4SabnbXSlxQzJ+j7v3uDdHnU6tlSG8HYiWqouVOotS7d46HQCRuuT2U99YYX8l9QkZ/Bimsb5qaGBd1WRV0XLmqqD71yUTsxhq3jJdhK9+UJae3Y59Voj2ejitrQEw9RpqMe0gP0WlL6VoDHB6B4eSCQfkLKSr+k3zk+4zjG4Azp3mHRr4hqe9q2v4aeGpG4nj95hIhlz7CFQ9f8aPGmerTWN9xthVcjJP5Nun0KOU5JtpisPGl6/QDxkxFbwYaky1A2BK7Rexz4k2I9C4IQzaaKVwe4l0/nRIMv6R21w4t06P0b3X7elwKGl03DPcpeYs7hulitVjHyvLBRxZ8MyQGbQ/UlyjJNt+qJyT9cLWstOrHavEFsb1Eij4BO35NdoNsRrpskshEFhteMrAuCNLvUytFZlNBL4y8/He1LVB/WuK41X7vYUxigS1S+1bsdVcqp61nEv1qnhUt9PYR2d2a8/Y/aTKkeNVklJFzXAidO0pD25DmMGP7ETIORnDhTwy0E3lPfWbfPQBh7MYZzYlPvrKkCzchpyWfeKhHHiUdAweVHVBHcnIP9id5ZSomaRzUX8sDuDsXEsgk60rNPlU39xJ86ReZu3giRJYBJX1X46YcgS7g52N/2KG+qMt4Q9B3rpwtmxjpNPLE+rhF6LppaxbdYoaemYkipCVuWZUAmk/CP4bQDeEoqrHSRVVwcwZxhcmkkxToK0gZFajPBY6XnDmXJMLZliQym7DNoH2/SN7NzPe1t+NrcWlxUJKxm6/QAwqo4wgSljh+pEqFI4N4lLaZM04fTeRRynQ4tIF4meZClmNOsWcL5t30uuc/c87ce4wRmqGMRHo75fgnyaALrmCInVi+3T5GmaoT/jApn1NQ4gdmiC+dnrbeumN58Fp7QMnGpE2xKQIvhZ03Gaj6P2VPh2iTmjlXirZujV61DsMSvD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB9094.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8IhAxIP91rZ6WrRvPouguRjZAfQf46VcgrqvUIhu6HvrU4PzZF0zfVocc1yBPnTNAFidTL58GyefDRXJ9Tk4YG6q/3Ym03Kiqef1zgUsVuN9aYQKLm8Fiybx91QWSbRon5HVdkDGh2iwWVGn7AgQH3nRdp94J5lLS+ePEHWEG6Do5e7RW6LN5ZetCFUzoBP+/1sat6VQ8FqA6JYqr+VbSmDz5TSIsEa9WSc/6TXp3VpZRyOXstIlM6SGdXKVkFM2HZYPlx2hPdpfKRiudSCLe3ZqNWbHtfFG0jC1jAsIWXxaOsxTbbGlUjxWme1rxul4r77mYqgZEQ8gfbxBJr1OIPKsMuUuycbL5CMOPQu0/GtJHkt5BsTVV6kOdtLp0Hcq3QQM9JxKdr4UHJvJncaC2N+fkajvYuYIq4Zu1lnLWol1HpLObDhgsMPiqgQULTkXxeNi/7B8OXlmca++q4kJrR+BBE1tZYhMlgMAnbGg0SW6XgCWzsXtWaXBrxN4f4tmzbpr2IVZWfAjF1Rtys95oQFUyw1bvJ7ZByu+3aC3PJzEtnraEUjp4/h1b9hZpxtvuCD/YHCJmu0uZNWl9T13N2hLRxtPjTOkw/S65hoUDt6IGR7HdsBSBuycHfjiSGChOgsh7a0O3WJ/hxrWQhxTzVmNSJE9Hk9bkR8L3Ph2HA/0za1mIPL8tUWGiVwhZHHaqb+e4LOlkB3vr5P+NuW8ZPC3AQVMMWA4Vc89EAZxPU/rNgZiiw5LXCO2WUWoSLNcyyZFESlKFE28XiuQEx3Tssv4cRhrADoO9X0ZpBYit7kyAWABMs3Z5wTt+cGzjEiDDnTnMYNA96Nv3wFOiPaqHUnPQyaj4ZbllgxcLfUZrwghIIwm6RcWo330Tx1wXS+zMvFvDVpQE+NPBL9DiLP4I6MknNrhFwzYG6dL7/uYWZZP5ZEPKfXK6Uq46aknhsyRfq3UBumVI74Uq/6rbwdbbjRowu5+4QYTHvsF4PdWdu8A13VmZYT703yLWBx29cJ9keqgT3wESa5eu8mv0A3Ja7Xo7pJ2a/s8eHgUOpFgtmHkQc4OoXDKQVAA1U0AtrZ+15IF4ntlBGpEEYxFRHLG94XpL61clsGrQccRzedh78KB8W/nkOrw68T3rY8Bmil84YuDRPFj2nbg4vv69+nCcxUQ+6wZW26VYll8sp2KDU5nnZlSsTddF2tjeTQbSQRIQWtorqBrVheoA2hhvNkEVK3yzCud/XsanSZqX4pbwCHhWm3GX+Ez56pvZNAwYXeVguX52uNgITY8SUoPfQ8RBvLGpHx/k5F2l/KhTRzNTzu34gLDvW01UI3rGFFgTM30yM3Sf1EIchicRzRCPMXVSjEOqMzsWr4huGlELGtDeGY3WPj9pgYEtZ+faXObXW3NIkRXwvRo4dteOx/a02Yl/G3tDCW0lSOfdToDyDvr5bslb+ay9Tm4s1tuIGzWP7+oZpsIZ9yJKoekjNAMm6keM7j03D1F1URbEHB2loGfmhUBr1F9utC2QSqWEO+RM+52M5dXIfjQZnnlTcxc5Sz1nxB5v5mv7gMfZB+Qe0hgXKKkG8xzBBx41tDicS4PaKdc7Bb/1ERSf9dCD7gABzTRZA== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc7191da-299b-42e9-1fe0-08dd1ea7ce7e X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9094.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2024 14:33:43.0597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pde+cw7EtTr/2dmPFZgnhG0XhL7As/yvQkiIgZA8lS6KZStlnis4qPoy062wMR9AaU93/6Ij6FZ2gK2+0i4EZbitY0wDZgSNERRLquOHrcw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7730 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensor ID may be required from IPA to be able to select specific tuning which can differ between sensors of the same model. For instance, sensors from the same model may have different lens for which different tuning is required. Hence this patch provides the sensor ID part of the image sensor characteristics IPACameraSensorInfo as defined in core.mojom IPA interface. Signed-off-by: Celine Laurencin --- include/libcamera/ipa/core.mojom | 9 +++++++++ src/libcamera/sensor/camera_sensor.cpp | 1 + 2 files changed, 10 insertions(+) diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom index bce79724..0ff643d2 100644 --- a/include/libcamera/ipa/core.mojom +++ b/include/libcamera/ipa/core.mojom @@ -134,6 +134,14 @@ module libcamera; * sensor model. */ +/** + * \var IPACameraSensorInfo::id + * \brief The image sensor id name + * + * The sensor id name is a free-formed string that uniquely identifies the + * sensor in the system. The ID satisfies the requirements to be used as a camera ID. + */ + /** * \var IPACameraSensorInfo::bitsPerPixel * \brief The number of bits per pixel of the image format produced by the @@ -239,6 +247,7 @@ module libcamera; */ struct IPACameraSensorInfo { string model; + string id; uint32 bitsPerPixel; uint32 cfaPattern; diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp index 5c89da07..fb3e172a 100644 --- a/src/libcamera/sensor/camera_sensor.cpp +++ b/src/libcamera/sensor/camera_sensor.cpp @@ -914,6 +914,7 @@ int CameraSensor::sensorInfo(IPACameraSensorInfo *info) const return -EINVAL; info->model = model(); + info->id = id(); /* * The active area size is a static property, while the crop