From patchwork Sun Dec 15 19:23:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22315 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E1DCEC32F5 for ; Sun, 15 Dec 2024 19:24:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9482467F11; Sun, 15 Dec 2024 20:24:07 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="jUR3sbWl"; dkim-atps=neutral Received: from mail-10628.protonmail.ch (mail-10628.protonmail.ch [79.135.106.28]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EDBB667EEE for ; Sun, 15 Dec 2024 20:24:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1734290643; x=1734549843; bh=XHA5l8iLhtlyKSsQfCRV3v+lxpOBR4ArLdHo5k549OQ=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=jUR3sbWlvmD3gFFiCuVRrlvhlJ0f0sCqQKn0fgNVsYPXP9E957iL1s7DayojX4HCP lxvxdcyXNBgi+L2ddZ5JT4lkNZtwda9Hwkrf6XfSnvvBMw2q3shK+UvOxEQqV5ZIvR 0140OVIuTFlAUNW6wJHbb4q2DkzEAkFfM3795WTyUeLqb1wTu8XAJ4MVh7nAsKbouR 7X8XcsQ/pMxDkOaDt8MSZ8gNQtVFvf6qAkx9u3dEQr9/NWWfrus0VtDUqCQN4eXmI0 KV7YMJ7ztxxF002YPNf29jBgW4d7XHBx+YH7A65rpZAHpOJ1iJ6V/0/H/i4qMumai0 nCx5jv2yDJjeA== Date: Sun, 15 Dec 2024 19:23:57 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [RFC PATCH v1] meson: Convert `v4l2` into a feature option Message-ID: <20241215192354.824108-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton X-Pm-Message-ID: c2c390dd00e65be8353317798e45164e0ef93e82 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The v4l2 compatibility layer does not have external dependencies, the usual benefits of a feature option do not apply. The main motivation behind this change is making use of the `auto_features` meson option that can change all feature options set to "auto" by default to the desired value. This can be useful for two reasons: (1) using auto_features=disabled and then building up the list of features that are desired in the particular build; (2) using auto_features=enabled to achieve (usually) more testing and compilation coverage. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- meson_options.txt | 4 ++-- src/v4l2/meson.build | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index c91cd241a..08e224561 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -84,6 +84,6 @@ option('udev', description : 'Enable udev support for hotplug') option('v4l2', - type : 'boolean', - value : false, + type : 'feature', + value : 'auto', description : 'Compile the V4L2 compatibility layer') diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build index 58f53bf3d..e4daf8ae7 100644 --- a/src/v4l2/meson.build +++ b/src/v4l2/meson.build @@ -1,6 +1,6 @@ # SPDX-License-Identifier: CC0-1.0 -if not get_option('v4l2') +if not get_option('v4l2').allowed() v4l2_enabled = false subdir_done() endif