From patchwork Thu Dec 12 10:24:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 22299 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D5C66C3260 for ; Thu, 12 Dec 2024 10:24:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8F2C867ECC; Thu, 12 Dec 2024 11:24:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="oSNecjB1"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1995B67EBF for ; Thu, 12 Dec 2024 11:24:20 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4361d5dcf5bso4517475e9.3 for ; Thu, 12 Dec 2024 02:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1733999059; x=1734603859; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5mcXS7UEHS3XMI0dNWbg+zMcd+IAmgGQoEiI5dQqKU8=; b=oSNecjB1aBMUjxlQGC87QanEEaMCW2vhRTcdpHDDn42yz7eOiY6wqbvnlydiPDAL87 eV6bj2Fp673G4q0NCmarD+8jjDpYycyeqiEwuDb6bGxNU/tXj48icqMC2UELsmWcx5p3 6NoH7MKenNCR7Bhb+LyUPR/emwr9v+OafFl5iFiAM7ISsPJSyDO0wSeHOFTa0MjkLYec 0Yv2fODvk9fay8MFNjVoLvLsFPVW4v0nJtxXtUxRULkIegEUNCjy/tI30E+sSu1tE3x9 10A1yo9a9Vjnzwqabmmrx6Gri2L4P4OH1wR1CYcaS2KyQT+APGhu8OkQr58pIz/jGqxN Q4FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733999059; x=1734603859; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5mcXS7UEHS3XMI0dNWbg+zMcd+IAmgGQoEiI5dQqKU8=; b=VwCrQ1Ya/JOY5p+WcPgm/JeuDZJigLrlNKU1AjsohLcdMhY4ScPN4q86ol6QjoACqc XFqpx5ZeHAYxp5hXv46WzIME993F/zuUufc9ZEatnG+aNBGF6dZLxCqMWqurA8UsCYn7 T5dAA/FuEI4j/pIBEc03y1LqBknOui1UwyeZqEbok7/+htGWvdumIKtNg1BxtwMh4Gbm elI6ZoIynuKoCMZj4tfwK5ST3BBxIjMDLGJVTxg8W0Ld3Ak80CGSrGFpr5mMvpbRN6Ku Kk75ihk0sq3/lxrqIeA/okOYp7sVryurkvSrorEFHfPAHHiTqPeubnapX//xCoQ0jjjS KK2w== X-Gm-Message-State: AOJu0Yzk7JRl6A8t/Ruzd5OepI92sipM1bsh+aBThZBwhFIZF3UfTFuk m6aNxlTgVQp3lHqBwx4gSerZjY6aTiK5dkPPQJF3/8l1GzmAyY6eLa5gtxwz12V7g0yvcq9+eIc Y X-Gm-Gg: ASbGncuorXBjz2CiiwWAUXP64h9rvzlmy7yZJxjXyIo4b+ToZHCIKPkK2XG8+SmF+JC ljrvR+kc5c8ffQodX2tZloaSzyPyXWZ+t5DhpanVwxJ4EmwbYVyHS8qr2K7FfbZSNWW7f4ZJcI6 uLLAcWe2G0ijdOYIJuseQPF0q/0vakKTaEl+An337FT+gsJfgHsacH4wbyravKeiGkwxBKugJMJ 2GJP9pZcejIVUTII0RBO+bEGWpaXMlReEV9U+w+WSFrvHpXic2VzfJFFi4GEC1G9Q4ottBC4kTD Yhst+RUiPXKI X-Google-Smtp-Source: AGHT+IHCjxDxwovLD81nZKNE9+S99wMV0W9LOJfeE35jM9+LEuapPtyAqGizOnDTt66KCeBLMCXg0A== X-Received: by 2002:a05:600c:3b13:b0:434:f335:849 with SMTP id 5b1f17b1804b1-4362288371emr21994855e9.29.1733999059365; Thu, 12 Dec 2024 02:24:19 -0800 (PST) Received: from raspberrypi.pitowers.org ([2a00:1098:3142:1f:c68a:6be1:5ba3:eddd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436255800f6sm12051855e9.18.2024.12.12.02.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 02:24:19 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman Subject: [PATCH] ipa: rpi: cam_helper: imx708: Correct the frame integration diff value Date: Thu, 12 Dec 2024 10:24:15 +0000 Message-Id: <20241212102415.8057-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This is the minimum permitted difference between the frame length and coarse exposure (both measured in lines). The correct value, taken from the datasheet, is 48. Signed-off-by: David Plowman Acked-by: Kieran Bingham Reviewed-by: Naushir Patuck --- src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp index ec83d9fd..16a017e9 100644 --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp @@ -66,7 +66,7 @@ private: * Smallest difference between the frame length and integration time, * in units of lines. */ - static constexpr int frameIntegrationDiff = 22; + static constexpr int frameIntegrationDiff = 48; /* Maximum frame length allowable for long exposure calculations. */ static constexpr int frameLengthMax = 0xffdc; /* Largest long exposure scale factor given as a left shift on the frame length. */