From patchwork Mon Dec 9 17:48:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 22264 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A8696BD80A for ; Mon, 9 Dec 2024 17:48:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9CA1967E73; Mon, 9 Dec 2024 18:48:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FBTWjL+U"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3807167E69 for ; Mon, 9 Dec 2024 18:48:12 +0100 (CET) Received: from pb-laptop.local (185.221.143.90.nat.pool.zt.hu [185.221.143.90]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F9C783D for ; Mon, 9 Dec 2024 18:47:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1733766460; bh=TIq/o2U8aiMo7e9ir94fSU/5FtT5nScZxkcpOc3FEAs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FBTWjL+U5lrec0NfA/RmG84Jzgp/so2k9ZmB0PRj3mJt2zgSfVXqMcZTaMoJX+SBw k2KYQo29INMasX+Q91DSfEERhV3Oe4VDdEQUZIERtbKcUXcQJrXzcfwjFnWb84dGMd Wwt9SaqLdzoW/HJcCPzsLEsWv++qycS0dVMLCrC0= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 3/6] Documentation: guides: pipeline-handler: Fix configuration creation Date: Mon, 9 Dec 2024 18:48:03 +0100 Message-ID: <20241209174806.283905-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241209174806.283905-1-barnabas.pocze@ideasonboard.com> References: <20241209174806.283905-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" `PipelineHandler::generateConfiguration()` returns an `std::unique_ptr`. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- Documentation/guides/pipeline-handler.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 1574fe738..ec5cf4d55 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -799,8 +799,7 @@ derived class, and assign it to a base class pointer. .. code-block:: cpp - VividCameraData *data = cameraData(camera); - CameraConfiguration *config = new VividCameraConfiguration(); + std::unique_ptr config = std::make_unique(); A ``CameraConfiguration`` is specific to each pipeline, so you can only create it from the pipeline handler code path. Applications can also generate an empty