From patchwork Mon Nov 25 15:30:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 22078 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AFA82C32A3 for ; Mon, 25 Nov 2024 15:30:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B3DFD66034; Mon, 25 Nov 2024 16:30:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Dn72Mo/d"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 33C8065F6B for ; Mon, 25 Nov 2024 16:30:17 +0100 (CET) Received: from neptunite.flets-east.jp (unknown [IPv6:2404:7a81:160:2100:9d06:dcbb:7303:4be6]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F71F6B5; Mon, 25 Nov 2024 16:29:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1732548595; bh=mX5StPOhw3lNpFAxIQJVyz+ZcGk92qAi9J2FXoJF/mI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dn72Mo/dIBG2jFESslevwmTHyZIFFDqZqvewPR6R5lfF1lgOZjoU3aZ/cJ3xMo1R4 QfcvAtfwZ/TlHTabjkz0A8oqUv4by/k29+8ooVPX08Owu1/KVNIRO5/y26BG0uO1HE VaJKDnv25FAL4QvIORRZ7De1xG6G6MN2J0B4kmZ0= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH 2/4] utils: codegen: controls.py: Parse direction information Date: Tue, 26 Nov 2024 00:30:01 +0900 Message-Id: <20241125153003.3309066-3-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241125153003.3309066-1-paul.elder@ideasonboard.com> References: <20241125153003.3309066-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In preparation for adding support for querying direction information from controls, parse the direction information from control ID definitions. This can later be plugged in directly to the IPA code generators simply by using ctrl.direction. Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart --- utils/codegen/controls.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/utils/codegen/controls.py b/utils/codegen/controls.py index 03c77cc64abe..bc1c655f1b9b 100644 --- a/utils/codegen/controls.py +++ b/utils/codegen/controls.py @@ -60,6 +60,15 @@ class Control(object): self.__size = num_elems + direction = self.__data.get('direction') + if direction is not None: + valid_values = ['in', 'out', 'inout'] + if direction not in valid_values: + raise RuntimeError(f'Control `{self.__name}` direction `{direction}` is invalid; must be one of `in`, `out`, or `inout`') + self.__direction = direction + else: + self.__direction = 'inout' + @property def description(self): """The control description""" @@ -111,6 +120,18 @@ class Control(object): else: return f"Span" + @property + def direction(self): + in_flag = 'static_cast(ControlId::Direction::In)' + out_flag = 'static_cast(ControlId::Direction::Out)' + + if self.__direction == 'inout': + return f'{in_flag} | {out_flag}' + if self.__direction == 'in': + return in_flag + if self.__direction == 'out': + return out_flag + @property def element_type(self): return self.__data.get('type')