From patchwork Sun Nov 24 19:29:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoffrey Van Landeghem X-Patchwork-Id: 22064 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6E754C3311 for ; Sun, 24 Nov 2024 19:30:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 710406600B; Sun, 24 Nov 2024 20:30:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M6rOg8zp"; dkim-atps=neutral Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 22DB866004 for ; Sun, 24 Nov 2024 20:30:01 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4349e4e252dso3658385e9.0 for ; Sun, 24 Nov 2024 11:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732476600; x=1733081400; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=neUXGfzfS0Z/CEm9uX4Za1tzbcsXlm78S0zLa/twTLo=; b=M6rOg8zp3PsR9h4K0DcETD7VHAOyqGUnvIIUuiphZsJrLsptSqEDWhWjwl/r1Opx4S 74USuRdpcEkc3dzuAaYgDkm1xHvcwv3lW/CMi718+SZB8yQkfQbgDsix4Rz57d+sFa0Y pnMg+PO3jR/qs8wL4LpvShW6cy+bal5n9v3aVCG5r8i3Qc5KBNHLF+dAwqz2kuhVuC/i jigeLHFj/bAEbcAN8R/UqAPrS81yTd1i66knSORVAg1Cz5thLqcv7OMH3q+4p/vbDTU7 kMFYkZxRmH9dIzTeln0VZGyZQgcWUvlnd28KYPs9iE0xxuLrO0mVXaJ02vclxEhu3Hf3 PGeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732476600; x=1733081400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=neUXGfzfS0Z/CEm9uX4Za1tzbcsXlm78S0zLa/twTLo=; b=MT8u8n76Yn14AoTqeHmLYXB9jaiXYc6OW9Ml7Wq9j8AGXJGrwu95WmPqsQBeuOdFNe LwH56nywSALitjkhVUBKququmDuT0rBgVs6a5whucHTHv3UnkFE0Yd4WO6G66zAA9QBP 09JtVHOwYqym8muhgyr/30zIrh/AieIHSRimeCwD9+XytZuxv6nncVt+aI9BxO6HYdUX o2V3RgWJpPplw+m6EpMZKAh7bz4IbxTdEp2IawZ6rnrNKKGlSNoWvOEZsDXyfyz2LLsN NMefEWRO+B/JXvu35My8w1ctDHATKEIey0p+zMU8/TNYBvk3hjGXjkc6ZLuj3crJ9XNa EUTg== X-Gm-Message-State: AOJu0YxZ0ROIznpnA/0JcZs6QUv6bGLud6dsqzbFgF/iejiLNOKV/irZ eETzlln7VfS5PaWfOeWWvNiyldmgUhF7XhtpDp4MPkcolrluiXAYKs4fBg== X-Gm-Gg: ASbGncuorGdgbuPJFVsuwRPXdFz2tSIGSabZr9QFjW4XgtYJjSC12WHxoJqQ0txG64s FQKHOORyLDFdB00nkDEV77ufNuUK4DLcQe2pcZfVr4UjNetwwNqtMxOuk5/OI2voRji1SsfSXzH 7hKeHo8fvK9HY+LN9l5935UIkTWJgaINVAwSVQP7S0x7guVtnv0u4VBhat5vCy3HxV3DdN2P2Gf Z+l6cGiQm9msnXBvnH2ptWAHPgsfZ83+hRAbtw47NbW/4/16MJkaYUnNoe+BRKbrT49v55hOQfN FIXiImeyzndw2K2LvP7PL5L3kWnnAmZuuEQu9vyvkO5a2T3eFQTwBJY= X-Google-Smtp-Source: AGHT+IFXjQrvwNbAXVntyCuxEJBhd63Hxz3VGYUcp3u85i9j5XsfRJLS9arYSqiWSxR+8o0c16Z92Q== X-Received: by 2002:a05:600c:4447:b0:431:55bf:fe4 with SMTP id 5b1f17b1804b1-433ce491837mr89917955e9.24.1732476599725; Sun, 24 Nov 2024 11:29:59 -0800 (PST) Received: from localhost.localdomain (ptr-gh3gmp9ck9bx99mg7lb.18120a2.ip6.access.telenet.be. [2a02:1812:2512:400:400a:4d18:885b:f46f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b463ab6csm169691645e9.35.2024.11.24.11.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2024 11:29:58 -0800 (PST) From: Geoffrey Van Landeghem To: libcamera-devel@lists.libcamera.org Cc: Geoffrey Van Landeghem Subject: [PATCH v3 5/5] libcamera: libipa: camera_sensor_helper: add IMX290 black level Date: Sun, 24 Nov 2024 20:29:50 +0100 Message-ID: <20241124192950.542686-6-geoffrey.vl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124192950.542686-1-geoffrey.vl@gmail.com> References: <20241124192950.542686-1-geoffrey.vl@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Report the default sensor black level reported by the datasheet. Note that IMX327 and IMX462 depend on the IMX290 CameraSensorHelper. That's fine since those sensors report the same defaults for the black level as the Sony IMX290. Signed-off-by: Geoffrey Van Landeghem Reviewed-by: Jacopo Mondi --- src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index f870dc28..07657700 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -576,6 +576,8 @@ class CameraSensorHelperImx290 : public CameraSensorHelper public: CameraSensorHelperImx290() { + /* From datasheet: 0xF0 at 12bits. */ + blackLevel_ = 3840; gainType_ = AnalogueGainExponential; gainConstants_.exp = { 1.0, expGainDb(0.3) }; }