From patchwork Mon Oct 21 16:45:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaslo Ziska X-Patchwork-Id: 21721 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2083FBD808 for ; Mon, 21 Oct 2024 16:50:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C26FE65393; Mon, 21 Oct 2024 18:50:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ziska.de header.i=@ziska.de header.b="jr53Ic8w"; dkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de header.b="qF/byXMG"; dkim-atps=neutral Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.21]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 217DD65392 for ; Mon, 21 Oct 2024 18:50:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1729529417; cv=none; d=strato.com; s=strato-dkim-0002; b=RcEzFhtjA2OmKFzqvM5DyfYQoqIg8W4IvhkuuLPX3NqK8NIgTALghN9vx7mdqKpAHM dmYGHUqS1pkV23IGEzYf/0+zqgfQYWlJlpuCceMOxn+zHxfwni9J4OKd0kYpQBfOS8kb 2NKFQuu6gDB5oq+/MlIWzTxyi1zc6HiS50yl+CBjGgwi87kv/pSAiL3EZWAbcTTm5fYK yNbgykdxOGpaGRRiaHrgwhzyUEgITmnXfU16Y8It/lJ4xBN/dzFNUdooDPZrqUVWSx3R uz+cKEHpLkXOVLc9cF2Nm3Ezfu/zbrjVxNaUUE2zP7BTPAOZjcDGFzmELn5lfcR982Pd bazQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1729529417; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=; b=nhubI8S1aqfQ6iyPrMVIyYZOxEs50Vm3lIYTy3tC7VvaiKCBhsVq3Z+MfvSWG5PS39 10NdMzfEYimOrqzkayoY21AxlB6ygdG9XDE1wLXROZAcZ6WVjIxX3ou1H15K+f0N3DBY o5TKbbvuE1enrSqgbiLi3JM49A+D05rwYlEQG5wbgWdEDi923mN5svpwtXZSa9yJFp4I yzGNjuu62U/hafFVJsZFDJvR2KWvwVfhpKn2S1HXO4vkOyAeT2MFQzQtjmkfnhkVIz+Y NKBkFKhfhoUCuBglPrRL916g8nK0K2S9Rk2Y1gsMY6lnUJ0GFm0wDVvtme7xG0JOka9M 6r8Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1729529417; s=strato-dkim-0002; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=; b=jr53Ic8wPIfG8hF2Z2zxEcSmhZOPVL/0k/6YwGbGucqwKa5Izys5ualuuTja9K4W4y CnJUzlDVXesX4sbku4sA01HaG6joyRbfP+TndCOoQ7YeGruHT8RIjRhBPTnB7GgnqoWO DzDdVBf24940wd01YyfIUsmMtmB7BaBw1o3N85uyM9/B5mcQ+Tuyk9As+rxl7TLFtmjZ orWKJub2bJHOdZfXYXjV2GbLiUUYiNxH3Di4HvhNynk0hv+cwNt5dcyUpwTa2h1G0CGQ axhtSmwzqbiDuZaLcnTxSuVoLe3R9DnU838Kire6/nlrFBKID0Yj97vlEXjAT6uvMPv5 hEiQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1729529417; s=strato-dkim-0003; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=; b=qF/byXMGflEgOlXPCL4PeFCvZakc/LdwqHjBtlKqR1pS6XRoTEm6Tyogg8LvlyAd+z 3kxsDFRN/OtRRRqvbzCw== X-RZG-AUTH: ":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cEiIqwXfJa0UVFIOBpUYAtVOpHIoJG1qZybSPb" Received: from archlinux.fritz.box by smtp.strato.de (RZmta 51.2.11 AUTH) with ESMTPSA id zf9ba109LGoHVdB (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 21 Oct 2024 18:50:17 +0200 (CEST) From: Jaslo Ziska To: libcamera-devel@lists.libcamera.org Cc: Jaslo Ziska , Laurent Pinchart , Kieran Bingham Subject: [PATCH v4 1/3] gstreamer: Remove auto-focus-mode property from device provider Date: Mon, 21 Oct 2024 18:45:31 +0200 Message-ID: <20241021164946.11111-2-jaslo@ziska.de> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241021164946.11111-1-jaslo@ziska.de> References: <20241021164946.11111-1-jaslo@ziska.de> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The device provider is not supposed to have control properties, remove the auto-focus-mode property which was introduced by accident. Fixes: 5a142438b025 ("gstreamer: Add enable_auto_focus option to the GStreamer plugin") Signed-off-by: Jaslo Ziska Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/gstreamer/gstlibcameraprovider.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index 4fb1b007..5da96ea3 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug); enum { PROP_DEVICE_NAME = 1, - PROP_AUTO_FOCUS_MODE = 2, }; #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() @@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, struct _GstLibcameraDevice { GstDevice parent; gchar *name; - controls::AfModeEnum auto_focus_mode = controls::AfModeManual; }; G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) @@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name) g_assert(source); g_object_set(source, "camera-name", GST_LIBCAMERA_DEVICE(device)->name, nullptr); - g_object_set(source, "auto-focus-mode", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr); return source; } @@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id, case PROP_DEVICE_NAME: device->name = g_value_dup_string(value); break; - case PROP_AUTO_FOCUS_MODE: - device->auto_focus_mode = static_cast(g_value_get_enum(value)); - break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); break; @@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass) (GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY)); g_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec); - - pspec = g_param_spec_enum("auto-focus-mode", - "Set auto-focus mode", - "Available options: AfModeManual, " - "AfModeAuto or AfModeContinuous.", - gst_libcamera_auto_focus_get_type(), - static_cast(controls::AfModeManual), - G_PARAM_WRITABLE); - g_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec); } static GstDevice *