From patchwork Fri Oct 18 15:30:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 21689 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D74FEC32FE for ; Fri, 18 Oct 2024 15:31:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 617CF6538B; Fri, 18 Oct 2024 17:31:31 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="g0T6kaYC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E45065394 for ; Fri, 18 Oct 2024 17:31:28 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:77a0:ddb9:22bf:b8d9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 97CF721C; Fri, 18 Oct 2024 17:29:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1729265384; bh=kkl+vFfasWNR2zoP9t8OzWrHjLHX6T7+Hp4tzuJQ9CA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g0T6kaYCYXf6SymEuBkTcS3VZbY1uu2BBdwa9rk/TXKFAY972B5yf86afj8S1NcBv utSu/aAKHWIDD2S3Jx0HKBZO5+nVPgwLkdNEtcSH6WEDz6KZ21vyJuEzK3u3TQHBN/ 7Tf1IuOlz8d14KnP0J2gj5dPOvb7fd4TQjfcZxew= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham , Laurent Pinchart , Paul Elder Subject: [PATCH v3 3/4] libcamera: controls: Add missing size to control_type Date: Fri, 18 Oct 2024 17:30:59 +0200 Message-ID: <20241018153116.925892-4-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241018153116.925892-1-stefan.klug@ideasonboard.com> References: <20241018153116.925892-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The size member is missing in control_type. This did not do any harm because the only control using the Point type was an array control. As soon as a control-id with a non-array Point control gets defined, the compile fails with: error: size is not a member of libcamera::details::control_type Fixes: 200d535ca85f ("libcamera: controls: Add ControlTypePoint") Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- Changes in v2: - Describe the error in commit message - Collected tags --- include/libcamera/controls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h index ca60bbacad17..28fec767fae1 100644 --- a/include/libcamera/controls.h +++ b/include/libcamera/controls.h @@ -101,6 +101,7 @@ struct control_type { template<> struct control_type { static constexpr ControlType value = ControlTypePoint; + static constexpr std::size_t size = 0; }; template