From patchwork Thu Oct 17 17:04:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaslo Ziska X-Patchwork-Id: 21660 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 58E25C32FC for ; Thu, 17 Oct 2024 17:24:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CC1FD65385; Thu, 17 Oct 2024 19:24:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ziska.de header.i=@ziska.de header.b="R36dKBjX"; dkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de header.b="7mtVtO/0"; dkim-atps=neutral Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.23]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7391965381 for ; Thu, 17 Oct 2024 19:24:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1729185864; cv=none; d=strato.com; s=strato-dkim-0002; b=HmVfs/TKxtErqQe8Av56ojXrpR2wRbmQIg0ljrHh7fOCBP+2RYG+55Zwmc1FOw2sp/ /xQ7gROCD5UmIUqs+x21wW3S8Y4/9Okt9v9xS4vUK8Po5n9WNavlVVrLVXNbwg2j/hQg FJymV5qr8c4RIeEo4R8I9JFkU9mHEDHZHyRiRWHJySNwiHHwNgIL3Vd00k0QeDxKg/Jm ClBHV8wQK3Q7BvUrw2WqstH8gJOZeD2RDCum82p+x6toIIFBb7/a10laIRRv2uw8W70g aTju9EcYtk5p+hL1P6xXSf8VH620EXG/jXt9Ikxw0TmbocdXsG27nRl0rWpiINBIjaR0 Yqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1729185864; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=T7O4CLfRFc2ELT+Lz3DYYfyc9JF05zwpoxEZNXxoYao=; b=jkxopZEzc6k2Qdk0VtHG59ij4L3HOJlAoEXArd19YmkGPIBicgJts+fFSFqlfRysDs sAdaH4Fe3YUTcKbpuMo/JGLfiN29o3zNli58zAcOhVvHfq0FnHcBKEM872SPHOToGZu2 fH6+G+EhauHqphqRpnh0mk/Jax2raDZrF69uDBD9jsLV8r+32fzygDBkyubchKpSJL2V BKPzoSB3v7wN5tJCWQ3ngsgskn+G1o54H0YqRBbDIfJ1veOCP2vZVOBznBiB2RRPa/y7 jq+UTlhHz/eto5tJo+PhNsdQ8pCeGB7Y6YVRn1Tw9YCgJ5XjxznHAzWKiTccUmNZZpNn I0OQ== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1729185864; s=strato-dkim-0002; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=T7O4CLfRFc2ELT+Lz3DYYfyc9JF05zwpoxEZNXxoYao=; b=R36dKBjXOWrnnCa32qvfNOZaXtP6JEkyrMgW/VDlauNatiHnbPOQC4Zgr+vV++nzhe 2Vf6I0UxrmfxJ5q0n6Kh4iSpTHvJmnTMpEBEBAVpk8yC1iEjJ4w1FExJSOlw32YzrTfJ 7J/JTjDWj3peiNVWIyN8Ohzgo4KUFMUU028cSMjvh8QtcCSF2uC6hLPwKId/JkMBl+2N wQ2byWSTVUrLcDPkqh0l0f9OMBBr7NgaWV9ztYT9Oud47CQ1nZm3JIum/GEn1N455rgd bNi8+TSU0qKyYYdzsYgwTceGsX7MQMeG+1/5x7LBHgQWiDWaQoSupli0RDuMO0r9Brs8 PPsQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1729185864; s=strato-dkim-0003; d=ziska.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=T7O4CLfRFc2ELT+Lz3DYYfyc9JF05zwpoxEZNXxoYao=; b=7mtVtO/0Em4X1p9eyj0Cmd7EsBNDKraoj0f4wjURTZsa30PSRcMbr5uka9XqAeo/zs nX9aU7E2AVjllaE5wSAw== X-RZG-AUTH: ":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cChoruAPJaMLnEXgE4US4SwNHvFuM4Ih4GFfdN" Received: from archlinux.fritz.box by smtp.strato.de (RZmta 51.2.11 AUTH) with ESMTPSA id zf9ba109HHOOI7H (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 17 Oct 2024 19:24:24 +0200 (CEST) From: Jaslo Ziska To: libcamera-devel@lists.libcamera.org Cc: Jaslo Ziska , Laurent Pinchart Subject: [PATCH v3 1/3] gstreamer: Remove auto-focus-mode property from device provider Date: Thu, 17 Oct 2024 19:04:13 +0200 Message-ID: <20241017172331.16377-2-jaslo@ziska.de> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241017172331.16377-1-jaslo@ziska.de> References: <20241017172331.16377-1-jaslo@ziska.de> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The device provider is not supposed to have control properties, remove the auto-focus-mode property which was introduced by accident. Fixes: 5a142438b025 ("gstreamer: Add enable_auto_focus option to the GStreamer plugin") Signed-off-by: Jaslo Ziska Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/gstreamer/gstlibcameraprovider.cpp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp index 4fb1b007..5da96ea3 100644 --- a/src/gstreamer/gstlibcameraprovider.cpp +++ b/src/gstreamer/gstlibcameraprovider.cpp @@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug); enum { PROP_DEVICE_NAME = 1, - PROP_AUTO_FOCUS_MODE = 2, }; #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type() @@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device, struct _GstLibcameraDevice { GstDevice parent; gchar *name; - controls::AfModeEnum auto_focus_mode = controls::AfModeManual; }; G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE) @@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name) g_assert(source); g_object_set(source, "camera-name", GST_LIBCAMERA_DEVICE(device)->name, nullptr); - g_object_set(source, "auto-focus-mode", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr); return source; } @@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id, case PROP_DEVICE_NAME: device->name = g_value_dup_string(value); break; - case PROP_AUTO_FOCUS_MODE: - device->auto_focus_mode = static_cast(g_value_get_enum(value)); - break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); break; @@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass) (GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY)); g_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec); - - pspec = g_param_spec_enum("auto-focus-mode", - "Set auto-focus mode", - "Available options: AfModeManual, " - "AfModeAuto or AfModeContinuous.", - gst_libcamera_auto_focus_get_type(), - static_cast(controls::AfModeManual), - G_PARAM_WRITABLE); - g_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec); } static GstDevice *